qpid-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Bares <jan.ba...@wood.cz>
Subject RE: QPID C++ broker monitoring and management
Date Tue, 11 Mar 2014 07:42:50 GMT
Hi Fraser, Rob and Robbie,

I am sorry for the confusion and your precious time, I should have known its SVN platform
issue :-). Yes, I use Windows SVN client, so I get the windows line endings on checkout. Fraser,
your last commit is just fine, now it works without any modifications. Just last small nitpick,
the comment "If we're on Cygwin we need to prepend the CLASSPATH with cygpath." is not accurate.
The cygpath [*] converts Unix path to windows path:

Before cygpath:
/cygdrive/c/Programs.Java/RedHat/qpid/qpid-qmf-gui/qpid-qmf-gui-trunk/build/lib/qpid-client-patch.jar:../../qpid/lib/*:/cygdrive/c/Programs.Java/RedHat/qpid/qpid-qmf-gui/qpid-qmf-gui-trunk/build/lib/qmf2.jar:/cygdrive/c/Programs.Java/RedHat/qpid/qpid-qmf-gui/qpid-qmf-gui-trunk/build/lib/restapi.jar

Cygpath returns:
C:\Programs.Java\RedHat\qpid\qpid-qmf-gui\qpid-qmf-gui-trunk\build\lib\qpid-client-patch.jar;C:\Programs.Java\RedHat\qpid\qpid-qmf-gui\qpid\lib\*;C:\Programs.Java\RedHat\qpid\qpid-qmf-gui\qpid-qmf-gui-trunk\build\lib\qmf2.jar;C:\Programs.Java\RedHat\qpid\qpid-qmf-gui\qpid-qmf-gui-trunk\build\lib\restapi.jar

As you can see, the path is converted to Windows path and also the classpath separator ":"
is converted to windows classpath separator ";". So I suggest to comment like: "On Cygwin
convert to Windows path" or no comment at all as this is clear from the code.

Many thanks, Jan

[*] http://cygwin.com/cygwin-ug-net/using-utils.html#cygpath

> -----Original Message-----
> From: Fraser Adams [mailto:fraser.adams@blueyonder.co.uk]
> Sent: Monday, March 10, 2014 9:31 PM
> To: users@qpid.apache.org
> Subject: Re: QPID C++ broker monitoring and management
>
> So am I correct in thinking that I'd need to do something like:
>
> |svn propset svn:eol-style LF <filename>|
>
> For all of the *.sh files then recommit?
>
> 'fraid I'm not especially familiar with the nuances of subversion
>
> Frase
>
> On 10/03/14 18:52, Robbie Gemmell wrote:
> > Read the link Rob sent and all should be clear.
> >
> > Robbie
> >
> > On 10 March 2014 18:01, Fraser Adams <fraser.adams@blueyonder.co.uk>
> wrote:
> >
> >> You've just confused me now Rob.
> >>  From what I can tell I've saved these files with UNIX style "\n" (0x0A)
> >> line endings and I'm using the standard Linux svn client so I doubt that's
> >> nobbling them into Windows style.
> >>
> >> I thought that your earlier mail was suggesting that Jan might have been
> >> using the Windows svn client and it was likely that which is converting the
> >> end of lines.
> >>
> >> So I'm not really sure what you are saying TBH
> >> Frase
> >>
> >>
> >>
> >> On 10/03/14 17:39, Rob Godfrey wrote:
> >>
> >>> Given that these are .sh files, I think it reasonable for us to change
> >>> them
> >>> to have LF eol-style in subversion... I'd imagine anything that ran on
> >>> windows that emulated a UNIX shell would handle files UNIX style line
> >>> endings, and it would make life easier for people using Cygwin by the
> >>> sounds of things.
> >>>
> >>> -- Rob
> >>>
> >>>
> >>> On 10 March 2014 18:25, Fraser Adams
> <fraser.adams@blueyonder.co.uk>
> >>> wrote:
> >>>
> >>>   Thanks Rob, that would be my guess too. I've just checked on gedit and
> if
> >>>> you do
> >>>> file->save as
> >>>>
> >>>> It gives you an option Line Ending and the default is Unix/Linux when
I
> >>>> hit save there there was no change to what I had previously so I'm
> pretty
> >>>> sure that I'm saving with Unix file endings.
> >>>>
> >>>> Just checked with a hex editor too and I'm just seeing 0x0A, so I think
> >>>> that what you are suggesting would seem about right.
> >>>>
> >>>> Frase
> >>>>
> >>>>
> >>>> On 10/03/14 17:10, Rob Godfrey wrote:
> >>>>
> >>>>   Is this a function of whichever svn client Jan is using under cygwin
> >>>>> assuming that "native" eol-style[1] for that platform is CRLF rather
> >>>>> than
> >>>>> LF.
> >>>>>
> >>>>> Given the files wouldn't normally work under windows except under
> Cygwin
> >>>>> perhaps changing the svn:eol-style of the .sh files to LF (rather
than
> >>>>> native as they are currently)?
> >>>>>
> >>>>> -- Rob
> >>>>>
> >>>>> [1]
> >>>>> http://svnbook.red-bean.com/en/1.7/svn.advanced.props.
> >>>>> file-portability.html#svn.advanced.props.special.eol-style
> >>>>>
> >>>>>
> >>>>> On 10 March 2014 18:00, Fraser Adams
> <fraser.adams@blueyonder.co.uk>
> >>>>> wrote:
> >>>>>
> >>>>>    Hi Jan,
> >>>>>
> >>>>>> I have to say that I don't really understand what you are getting
at
> >>>>>> with
> >>>>>> some of these comments - especially "Is there any reason why
you
> use
> >>>>>> Windows line endings?"
> >>>>>>
> >>>>>> I'm using a Linux box - always have done. I generally use gedit
on
> >>>>>> Linux
> >>>>>> to edit and these scripts are no exception.
> >>>>>>
> >>>>>>
> >>>>>> On 10/03/14 09:31, Jan Bares wrote:
> >>>>>>
> >>>>>>    Hi Fraser,
> >>>>>>
> >>>>>>> Thank you for the change, it works fine, I just have to
convert to
> >>>>>>> Unix
> >>>>>>> line endings. Yes, the cygpath must be called before you
use it.
> What
> >>>>>>> I
> >>>>>>> meant was to keep just the Cygwin detection code at the
script
> begin.
> >>>>>>> Is
> >>>>>>> there any reason why you use Windows line endings? I do
not have
> deep
> >>>>>>> Cygwin knowledge, but all shell scripts that have Cygwin
support
> >>>>>>> inside,
> >>>>>>> such as Tomcat catalina.sh, use Unix line endings. See
> >>>>>>>
> http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?view=log.
> >>>>>>> There you can also see support for Darwin and os400 embedded.
> >>>>>>>
> >>>>>>> Thanks you, Jan
> >>>>>>>
> >>>>>>>     -----Original Message-----
> >>>>>>>
> >>>>>>>   From: Fraser Adams [mailto:fraser.adams@blueyonder.co.uk]
> >>>>>>>> Sent: Saturday, March 08, 2014 2:12 PM
> >>>>>>>> To: users@qpid.apache.org
> >>>>>>>> Subject: Re: QPID C++ broker monitoring and management
> >>>>>>>>
> >>>>>>>> Hi Jan,
> >>>>>>>> I've committed an update to QpidRestAPI.sh on trunk.
Could you
> please
> >>>>>>>> check to see if that works and give me a yell. If it
works then I'll
> >>>>>>>> update the other scripts.
> >>>>>>>>
> >>>>>>>> BTW I've added the Cygwin stuff *after* I set CLASSPATH
to
> >>>>>>>>
> >>>>>>>> CLASSPATH=$QMF2_LIBS/qpid-client-
> >>>>>>>>
> patch.jar:$CLASSPATH:$QMF2_LIBS/qmf2.jar:$QMF2_LIBS/restapi.jar
> >>>>>>>>
> >>>>>>>> myself because the qpid-client-patch.jar gets put *before*
the
> main
> >>>>>>>> CLASSPATH (which would have the qpid jars on it). That's
a bit
> quirky
> >>>>>>>> but that patch is an optional thing for people running
< Qpid 0.12 it
> >>>>>>>> provides a "patch" to one of the classes on that to
enable the
> >>>>>>>> "x-amqp-0-10.app-id" property to be added, which is
needed for
> QMF
> >>>>>>>> (see
> >>>>>>>> the README.txt)
> >>>>>>>>
> >>>>>>>> Hopefully nobody is using that stuff now, but you never
know :-)
> but
> >>>>>>>> given that I *think* that I need to add your:
> >>>>>>>>
> >>>>>>>>        CLASSPATH=$(cygpath -wp $CLASSPATH)
> >>>>>>>>
> >>>>>>>> After I've set the CLASSPATH.
> >>>>>>>>
> >>>>>>>> Just in case you are wondering why I didn't just shove
the Cygwin
> >>>>>>>> block
> >>>>>>>> at the start.
> >>>>>>>>
> >>>>>>>> Let me know if it works and I'll fix the other scripts
ASAP.
> >>>>>>>>
> >>>>>>>> Regards,
> >>>>>>>> Frase
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>   DISCLAIMER
> >>>>>>> ________________________________
> >>>>>>>              WOOD & Company Financial Services, a.s.
and its branches
> >>>>>>> are
> >>>>>>> authorized and regulated by the CNB as Home State regulator
and
> in
> >>>>>>> Poland
> >>>>>>> by the KNF, in Slovakia by the NBS and in the UK by the
FCA as Host
> >>>>>>> State
> >>>>>>> regulators. For further information about WOOD & Co.,
its
> investment
> >>>>>>> services, financial instruments and associated risks, safeguard
client
> >>>>>>> assets (incl. compensation schemes) and contractual relationship
> >>>>>>> please
> >>>>>>> see
> >>>>>>> our website at www.wood.com<http://www.wood.com/>
under
> section
> >>>>>>> Corporate Governance.
> >>>>>>>              Unless otherwise stated, this transmission
is neither an
> >>>>>>> offer
> >>>>>>> nor the solicitation of an offer to sell or purchase any
investment.
> >>>>>>> All
> >>>>>>> estimates, opinions and other information contained herein
are
> subject
> >>>>>>> to
> >>>>>>> change without notice and are provided in good faith but
without
> legal
> >>>>>>> responsibility or liability. Opinion may be personal to
the author and
> >>>>>>> may
> >>>>>>> not reflect the opinions of WOOD & Co. Communications
from sales
> >>>>>>> persons,
> >>>>>>> sales traders or traders should not be regarded as investment
> research
> >>>>>>> and
> >>>>>>> may contain opinions or trading ideas which are different
from
> WOOD &
> >>>>>>> Co.
> >>>>>>> investment research opinions.
> >>>>>>>              This e-mail and any attachments are confidential
and may
> >>>>>>> be
> >>>>>>> privileged or otherwise protected from disclosure. If you
are not a
> >>>>>>> named
> >>>>>>> addressee you must not use, disclose, distribute, copy,
print or rely
> >>>>>>> on
> >>>>>>> this e-mail and any of its attachments. Please notify the
sender that
> >>>>>>> you
> >>>>>>> have received this email by mistake by replying to the email,
and
> then
> >>>>>>> delete the email and any copies of it. Although WOOD &
Co.
> routinely
> >>>>>>> screens e-mails for viruses, addressees should scan this
e-mail and
> >>>>>>> any
> >>>>>>> attachments for viruses. WOOD & Co. makes no representation
or
> >>>>>>> warranty
> >>>>>>> as
> >>>>>>> to the absence of viruses in this e-mail or any attachments.
Please
> >>>>>>> note
> >>>>>>> that to ensure regulatory compliance and for the protection
of our
> >>>>>>> clients
> >>>>>>> and business, we may monitor and read e-mails sent to and
from
> our
> >>>>>>> server(s).
> >>>>>>> ________________________________
> >>>>>>>
> >>>>>>> ---------------------------------------------------------------------
> >>>>>>> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> >>>>>>> For additional commands, e-mail: users-help@qpid.apache.org
> >>>>>>>
> >>>>>>>
> >>>>>>>    ------------------------------------------------------------
> >>>>>>> ---------
> >>>>>>>
> >>>>>> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> >>>>>> For additional commands, e-mail: users-help@qpid.apache.org
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>   ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> >>>> For additional commands, e-mail: users-help@qpid.apache.org
> >>>>
> >>>>
> >>>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> >> For additional commands, e-mail: users-help@qpid.apache.org
> >>
> >>




DISCLAIMER
________________________________
         WOOD & Company Financial Services, a.s. and its branches are authorized and regulated
by the CNB as Home State regulator and in Poland by the KNF, in Slovakia by the NBS and in
the UK by the FCA as Host State regulators. For further information about WOOD & Co.,
its investment services, financial instruments and associated risks, safeguard client assets
(incl. compensation schemes) and contractual relationship please see our website at www.wood.com<http://www.wood.com/>
under section Corporate Governance.
         Unless otherwise stated, this transmission is neither an offer nor the solicitation
of an offer to sell or purchase any investment. All estimates, opinions and other information
contained herein are subject to change without notice and are provided in good faith but without
legal responsibility or liability. Opinion may be personal to the author and may not reflect
the opinions of WOOD & Co. Communications from sales persons, sales traders or traders
should not be regarded as investment research and may contain opinions or trading ideas which
are different from WOOD & Co. investment research opinions.
         This e-mail and any attachments are confidential and may be privileged or otherwise
protected from disclosure. If you are not a named addressee you must not use, disclose, distribute,
copy, print or rely on this e-mail and any of its attachments. Please notify the sender that
you have received this email by mistake by replying to the email, and then delete the email
and any copies of it. Although WOOD & Co. routinely screens e-mails for viruses, addressees
should scan this e-mail and any attachments for viruses. WOOD & Co. makes no representation
or warranty as to the absence of viruses in this e-mail or any attachments. Please note that
to ensure regulatory compliance and for the protection of our clients and business, we may
monitor and read e-mails sent to and from our server(s).
________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Mime
View raw message