qpid-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fraser Adams <fraser.ad...@blueyonder.co.uk>
Subject Re: Request for inclusion in 0.24 - fix to QPID-5005
Date Fri, 19 Jul 2013 12:35:55 GMT
Hey again Justin,
With respect to the other two errors I noticed on 0.24 but not on trunk 
I've just looked and noticed that the Session.java file in 
tools/src/java/src/qpid-broker-plugins-management-qmf2/java/org/apache/qpid/server/qmf2/agentdata

is present in trunk but not in 0.24. I'm slightly worried by that given 
that I'm pretty certain I added that file quite a while ago and checking 
the file properties is says "Sat 20 Apr 2013 18:35:47 BST" for the 
modified time, so I'm a bit concerned about the state of some stuff that 
got pulled into the 0.24 branch.

Am I losing my marbles?

Frase


On 19/07/13 13:14, Fraser Adams wrote:
> Hi Justin,
> I just noticed today that the Java Broker Plugin API has changed to 
> need overridden getType() method in instances of PluginFactory.
>
> I raised QPID-5005 and fixed this on trunk with:
>
> — 
> qpid/tools/src/java/src/qpid-broker-plugins-management-qmf2/java/org/apache/qpid/server/qmf2/QmfManagementFactory.java

> (revision 1504825)
> +++ 
> qpid/tools/src/java/src/qpid-broker-plugins-management-qmf2/java/org/apache/qpid/server/qmf2/QmfManagementFactory.java

> (working copy)
> @@ -76,4 +76,10 @@
> return null;
> }
> }
> +
> + @Override
> + public String getType()
> +
>
> { + return "QMF2 Management"; + }
>
> }
>
>
> I've just checked the 0.24 release branch and that barfs with
>
> "QmfManagementFactory is not abstract and does not override abstract 
> method getType() in org.apache.qpid.server.plugin.Pluggable
>
> "
>
>
> Actually on 0.24 I seem to be getting a couple of other errors :-(
>
> "ins-management-qmf2/java/org/apache/qpid/server/qmf2/QmfManagementAgent.java:172: 
> cannot find symbol
> [javac] symbol : class Session
> [javac] location: package org.apache.qpid.server.qmf2.agentdata
> [javac] 
> _agent.registerObjectClass(org.apache.qpid.server.qmf2.agentdata.Session.getSchema());
> [javac] ^
> [javac] 
> /home/fadams/qpid/qpid-0.24/qpid/tools/src/java/src/qpid-broker-plugins-management-qmf2/java/org/apache/qpid/server/qmf2/QmfManagementAgent.java:374:

> cannot find symbol
> [javac] symbol : class Session
> [javac] location: package org.apache.qpid.server.qmf2.agentdata
> [javac] data = new 
> org.apache.qpid.server.qmf2.agentdata.Session((Session)child, 
> ref.getObjectId());
> [javac]
>
> "
>
> Which I don't seem to be getting on trunk - there might be some 
> differences to some of the stuff Robbie and Rob have been working on 
> between trunk and 0.24.
>
>
> Frase
>
>
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Mime
View raw message