Mailing-List: contact proton-help@qpid.apache.org; run by ezmlm
Precedence: bulk
Reply-To: proton@qpid.apache.org
Date: Wed, 18 Dec 2013 23:42:06 +0000 (UTC)
From: "Frank Quinn (JIRA)" <jira@apache.org>
To: proton@qpid.apache.org
Message-ID: <JIRA.12667215.1378423437953.61369.1387410126940@arcas>
In-Reply-To: <JIRA.12667215.1378423437953@arcas>
References: <JIRA.12667215.1378423437953@arcas>
Subject: [jira] [Commented] (PROTON-420) Warnings Presented When Using
 Strict Compiler Flags
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/PROTON-420?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1385=
2319#comment-13852319 ]=20

Frank Quinn commented on PROTON-420:
------------------------------------

Attached patch which resolves issues.

> Warnings Presented When Using Strict Compiler Flags
> ---------------------------------------------------
>
>                 Key: PROTON-420
>                 URL: https://issues.apache.org/jira/browse/PROTON-420
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.5
>         Environment: GCC 4.4.7
>            Reporter: Frank Quinn
>         Attachments: FIX-Warnings-Presented-When-Using-Strict-Compiler-Fl=
ags-PROTON-420.patch
>
>
> Hi Folks,
> In our project, we currently use the following compiler flags for gcc (te=
sted in version 4.4.7):
> -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-prototy=
pes -Werror
> Unfortunately this causes problems in recent versions of proton as its he=
aders produce some warnings of their own. The ones we have spotted can be r=
ecreated using the following code:
> #include <proton/error.h>
> #include <proton/messenger.h>
> int main(){}
> Compiled with:
> $ gcc -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-p=
rototypes -Werror -I./qpid-proton-0.5/proton-c/include/ test.c -o test
> cc1: warnings being treated as errors
> In file included from test.c:1:
> ./qpid-proton-0.5/proton-c/include/proton/error.h:46: error: function dec=
laration isn=E2=80=99t a prototype
> In file included from test.c:2:
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:458:29: error: "/*"=
 within comment
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:466:40: error: "/*"=
 within comment
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:470:32: error: "/*"=
 within comment
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:475:34: error: "/*"=
 within comment
> test.c:4: error: function declaration isn=E2=80=99t a prototype
> The first one can be resolved by changing pn_error() to pn_error(void) an=
d the others can be fixed simply by adding some spacing. We typically just =
hack our local copies for testing, but we figured it may be better to get t=
his into the main code stream if you guys can find the time to put it in.
> Cheers,
> Frank=20


--
This message was sent by Atlassian JIRA
(v6.1.4#6159)