qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1739) Use GitHub Actions w/ sharding and bubblewrap for some fast CI
Date Tue, 04 Aug 2020 16:36:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170942#comment-17170942
] 

ASF GitHub Bot commented on DISPATCH-1739:
------------------------------------------

gemmellr commented on a change in pull request #809:
URL: https://github.com/apache/qpid-dispatch/pull/809#discussion_r465181148



##########
File path: .github/workflows/build.yaml
##########
@@ -0,0 +1,165 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Build
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-20.04]
+        buildType: [RelWithDebInfo]
+    env:
+      BuildType: ${{matrix.buildType}}
+      ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+      DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+      InstallPrefix: ${{github.workspace}}/install
+      ProtonCMakeExtraArgs: '-DBUILD_BINDINGS=python'
+      DispatchCMakeExtraArgs: ''
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          repository: 'apache/qpid-proton'
+          ref: 'master'
+          path: 'qpid-proton'
+      - uses: actions/checkout@v2
+        with:
+          path: 'qpid-dispatch'
+      - name: actions/cache@v2 node-modules
+        uses: actions/cache@v2
+        env:
+          cache-name: cache-node-modules
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json')
}}
+          restore-keys: |
+            ${{ runner.os }}-build-${{ env.cache-name }}-
+            ${{ runner.os }}-build-
+            ${{ runner.os }}-
+      - name: Create Build and Install directories
+        run: mkdir -p "${ProtonBuildDir}" "${DispatchBuildDir}" "{InstallPrefix}"
+        shell: bash
+      - name: Setup python
+        uses: actions/setup-python@v2
+        with:
+          python-version: 3.6
+          architecture: x64
+      - name: Install python dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install setuptools wheel tox
+      - name: Install Linux dependencies
+        if: ${{ runner.os == 'Linux' }}
+        run: |
+          sudo apt install -y swig ninja-build libpython3-dev libsasl2-dev libjsoncpp-dev
libwebsockets-dev xz-utils
+      - name: qpid-proton cmake configure
+        working-directory: ${{env.ProtonBuildDir}}
+        run: cmake "${{github.workspace}}/qpid-proton" "-DCMAKE_INSTALL_PREFIX=${InstallPrefix}"
"-DCMAKE_BUILD_TYPE=${BuildType}" "-DBUILD_TESTING=OFF" "-DENABLE_FUZZ_TESTING=OFF" "-GNinja"
${ProtonCMakeExtraArgs}
+        shell: bash
+      - name: qpid-proton cmake build/install
+        run: cmake --build "${ProtonBuildDir}" --config ${BuildType} -t install
+        shell: bash
+      - name: qpid-dispatch cmake configure
+        working-directory: ${{env.DispatchBuildDir}}
+        run: cmake "${{github.workspace}}/qpid-dispatch" "-DCMAKE_INSTALL_PREFIX=${InstallPrefix}"
"-DCMAKE_BUILD_TYPE=${BuildType}" "-GNinja" "-DUSE_BWRAP=ON" ${DispatchCMakeExtraArgs}
+        shell: bash
+      - name: qpid-dispatch cmake build/install
+        run: cmake --build "${DispatchBuildDir}" --config ${BuildType} -t install
+        shell: bash
+      # github actions/upload-artifact@v2 does not preserve file permissions (executable)
+      - name: Compress build
+        working-directory: ${{github.workspace}}
+        run: tar --xz -cf /tmp/archive.tar.xz --exclude '*.o' --exclude '*.pyc' --exclude
'.git' --exclude='qpid-dispatch/build/console' qpid-dispatch install qpid-proton/build/python/pkgs
+      - name: Upload archive
+        uses: actions/upload-artifact@v2
+        with:
+          name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+          path: /tmp/archive.tar.xz
+  test:
+    name: "Test (${{matrix.os}}, shard ${{matrix.shard}} of ${{matrix.shards}}"
+    runs-on: ${{ matrix.os }}
+    needs: [build]
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-20.04]
+        buildType: [RelWithDebInfo]
+        shard: [1, 2, 3, 4]
+        shards: [4]
+    env:
+      BuildType: ${{matrix.buildType}}
+      ProtonBuildDir: ${{github.workspace}}/qpid-proton/build
+      DispatchBuildDir: ${{github.workspace}}/qpid-dispatch/build
+      InstallPrefix: ${{github.workspace}}/install
+      PKG_CONFIG_PATH: ${{matrix.pkg_config_path}}
+      LD_LIBRARY_PATH: ${{github.workspace}}/install/lib
+    steps:
+      - name: Download Build
+        uses: actions/download-artifact@v2
+        with:
+          name: qpid_dispatch_wrk_${{matrix.os}}_${{matrix.buildType}}
+      - name: Setup python
+        uses: actions/setup-python@v2
+        with:
+          python-version: 3.6
+          architecture: x64
+      - name: Install python dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install tox
+      - name: Install Linux dependencies
+        if: ${{ runner.os == 'Linux' }}
+        run: |
+          sudo apt install -y bubblewrap swig ninja-build libsasl2-2 sasl2-bin libjsoncpp1
libwebsockets15 xz-utils
+      - name: Install MacOS dependencies
+        if: ${{ runner.os == 'macOS' }}
+        run: |
+          brew install cmake ninja libuv swig pkgconfig jsoncpp openssl libwebsockets
+      - name: Unpack archive
+        run: tar --xz -xf archive.tar.xz
+      - name: install qpid-proton python wheel
+        run: python -m pip install ${ProtonBuildDir}/python/pkgs/python_qpid_proton*.whl
+        shell: bash
+      - name: CTest
+        working-directory: ${{env.DispatchBuildDir}}
+        run: |
+          ulimit -c unlimited
+          ctest -C ${BuildType} -V -T Test --no-compress-output -I ${{matrix.shard}},,${{matrix.shards}}
-j2
+        shell: bash
+      - name: Upload test results
+        uses: actions/upload-artifact@v2
+        if: ${{ ! cancelled() }}
+        with:
+          name: Test_Results_${{matrix.os}}_${{matrix.buildType}}_${{matrix.shard}}
+          path: ${{env.DispatchBuildDir}}/Testing/**/*.xml
+      - name: Upload core files
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: cores_${{matrix.os}}_${{matrix.buildType}}_${{matrix.shard}}
+          path: |
+            **/core
+      - name: Environment (Linux)

Review comment:
       Same comment would apply to proton if I'd thought of it at the time :) Just seems more
usual to care about the env at the start rather than end, e.g all the stuff about the node
etc is usually at the start.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use GitHub Actions w/ sharding and bubblewrap for some fast CI
> --------------------------------------------------------------
>
>                 Key: DISPATCH-1739
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1739
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.12.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>             Fix For: 1.13.0
>
>
> GitHub Actions is a task runner associated with a GitHub project. It is conceptually
similar to Travis, except that it has some extra features, and the waits for computational
resources are much shorter (currently).
> Sharding is a technique to speed up the execution of tests. Instead of running the tests
on one machine one after another, copy the build directory over to multiple machines, say
two, and have the first execute the odd-numbered and the second one the even-numbered tests.
With luck (if copying the build directory is relatively fast, and the tests all take approximately
the same time), this will cut the execution time in half.
> Bubblewrap (https://github.com/containers/bubblewrap) is a sandboxing tool available
on Ubuntu and other systems. It is similar to systemd-nspawn except it does not require sudo
or user namespace support in the kernel. It is similar to docker, except it does not use images,
instead it selectively mounts directories from the host. Bubblewrap can create an isolated
network namespace, which allows running multiple tests at the same time, each in its own bubblewrap
sandbox, and they don't clash on ports. With bubblewrap, running {{ctest -j4}} is safe.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message