From dev-return-103691-archive-asf-public=cust-asf.ponee.io@qpid.apache.org Tue Jul 28 14:31:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id E3882180665 for ; Tue, 28 Jul 2020 16:31:03 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 2587112528A for ; Tue, 28 Jul 2020 14:31:02 +0000 (UTC) Received: (qmail 64026 invoked by uid 500); 28 Jul 2020 14:31:01 -0000 Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list dev@qpid.apache.org Received: (qmail 64010 invoked by uid 99); 28 Jul 2020 14:31:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jul 2020 14:31:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C937B42FE4 for ; Tue, 28 Jul 2020 14:31:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 16D317804B2 for ; Tue, 28 Jul 2020 14:31:00 +0000 (UTC) Date: Tue, 28 Jul 2020 14:31:00 +0000 (UTC) From: =?utf-8?Q?Jiri_Dan=C4=9Bk_=28Jira=29?= To: dev@qpid.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DISPATCH-1727) Dispatch Console mixes usage of `npm` with `yarn` MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DISPATCH-1727?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1= 7166464#comment-17166464 ]=20 Jiri Dan=C4=9Bk commented on DISPATCH-1727: -------------------------------------- Do you intend to keep yarn.lock in place? That would mean keeping two files= which essentially overlap/duplicate each other. I was originally thinking = of picking one or the other, not both... > Dispatch Console mixes usage of `npm` with `yarn` > ------------------------------------------------- > > Key: DISPATCH-1727 > URL: https://issues.apache.org/jira/browse/DISPATCH-1727 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console > Affects Versions: 1.12.0 > Reporter: Jiri Dan=C4=9Bk > Assignee: Ernest Allen > Priority: Critical > Fix For: 2.0.0 > > > There is a `yarn.lock` file checked into the repository, but CMake build = file is using straight `npm` to build the console. > This means that the content of `yarn.lock` is used during Console develop= ment (if yarn is used to build and test the console) and it is ignored when= CMake is building Dispatch Console for deployment. > There is a package locking mechanism in npm since npm version 5. It is `p= ackage-lock.json`. We should decide if we want to use yarn or npm, and use = the corresponding command in CMake, and use the correct lock file. > The decision should take into account users of Dispatch, who may not have= access to npm 5, possibly. I am not sure if this is relevant consideration= . -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org For additional commands, e-mail: dev-help@qpid.apache.org