qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [qpid-dispatch] jiridanek commented on pull request #294: DISPATCH-960 - Resolving service port when using http listener
Date Thu, 23 Jul 2020 14:55:49 GMT

jiridanek commented on pull request #294:
URL: https://github.com/apache/qpid-dispatch/pull/294#issuecomment-663054639


   @gemmellr It already does what it is supposed to do, so I thought it is ready to be merged.
The improvement is there, macOS travis job is allowed to fail, and the behavior on invalid
protocol name is not any worse than it was before.
   
   I did not close the Jira because I was planning to revisit the issue regarding my comments,
either myself when there is the c_unittests pr merged, which should be soon now, or see if
@fgiorgetti maybe fixes it in the meantime.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message