qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [qpid-proton] astitcher commented on pull request #263: PROTON-2244: Fix for Array of lists with first list empty encoding
Date Mon, 06 Jul 2020 15:53:43 GMT

astitcher commented on pull request #263:
URL: https://github.com/apache/qpid-proton/pull/263#issuecomment-654321007


   @kpvdr Thanks for adding regression tests for this bug.
   We're trying to avoid adding C unit tests in python with a long term aim of avoiding python
for the C unit tests completely. So it'd be great to put them in the existing unit test file
c/tests/data_test.cpp.
   You can use C++ in these unit tests (as we are already using a C++ unit test framework)
which allows much of the same convenience as writing the tests in python.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message