qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-1566) safe_snpritf is not safe.
Date Wed, 12 Feb 2020 11:56:00 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035318#comment-17035318
] 

ASF GitHub Bot commented on DISPATCH-1566:
------------------------------------------

nicob87 commented on issue #679: DISPATCH-1566: fix safe_snptrintf
URL: https://github.com/apache/qpid-dispatch/pull/679#issuecomment-584812640
 
 
   Test error is only in the RelWithDebInfo build, and it is in the tear down, If I am not
wrong it is not related to this pr.
   
   ```
   51: ======================================================================
   51: ERROR: tearDownClass (system_tests_edge_router.LinkRouteProxyTest)
   51: ----------------------------------------------------------------------
   51: Traceback (most recent call last):
   51:   File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 691, in
tearDownClass
   51:     cls.tester.teardown()
   51:   File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 637, in
teardown
   51:     raise RuntimeError("Errors during teardown: \n\n%s" % "\n\n".join([str(e) for e
in errors]))
   51: RuntimeError: Errors during teardown: 
   51: 
   51: Process 14088 error: exit code 23, expected 0
   51: qdrouterd -c EB1.conf -I /home/travis/build/apache/qpid-dispatch/python
   51: /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_edge_router/LinkRouteProxyTest/setUpClass/EB1-8.cmd
   51: >>>>
   ```
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> safe_snpritf is not safe.
> -------------------------
>
>                 Key: DISPATCH-1566
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1566
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Router Node
>    Affects Versions: 1.10.0
>            Reporter: Nicolas
>            Priority: Major
>             Fix For: 1.11.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> {{/* **************************************** */}}
> {{static inline int safe_snprintf(char *str, size_t size, const char *format, ...)}}
> {{{ .... }}{{}}}
> This function fails for size = 0, and ... inside it calls vsnprintf, without considering
that in case of error vsnprintf returns a negative number.
> PR in progress.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message