qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-2140) proton-c has very high memory footprint for links
Date Thu, 21 Nov 2019 22:11:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979653#comment-16979653
] 

ASF GitHub Bot commented on PROTON-2140:
----------------------------------------

astitcher commented on pull request #213: PROTON-2140: Lazy creation of various link related
objects
URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349342449
 
 

 ##########
 File path: c/src/core/codec.c
 ##########
 @@ -655,7 +693,7 @@ int pn_data_vfill(pn_data_t *data, const char *fmt, va_list ap)
         if (parent->atom.type == PN_ARRAY) {
           parent->type = (pn_type_t) va_arg(ap, int);
         } else {
-          return pn_error_format(data->error, PN_ERR, "naked type");
+          return pn_error_format(pn_data_error(data), PN_ERR, "naked type");
 
 Review comment:
   Small nit: these should all probably explicitly be the inlined version now `pni_data_error`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> proton-c has very high memory footprint for links
> -------------------------------------------------
>
>                 Key: PROTON-2140
>                 URL: https://issues.apache.org/jira/browse/PROTON-2140
>             Project: Qpid Proton
>          Issue Type: Improvement
>            Reporter: Gordon Sim
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message