qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #581: DISPATCH-1442 - Added annotation field to the router entity.
Date Mon, 07 Oct 2019 13:08:55 GMT
ted-ross commented on a change in pull request #581: DISPATCH-1442 - Added annotation field
to the router entity.
URL: https://github.com/apache/qpid-dispatch/pull/581#discussion_r332007734
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -493,6 +493,12 @@
                     "create": true,
                     "required": false,
                     "default": "balanced"
+                },
+                "annotation": {
+                    "type": "string",
+                    "description": "Annotation text for this router, to be used by user or
orchestration layers.",
 
 Review comment:
   Suggestions are welcome...
   How about "Optional annotation text for this router.  This may be used by the console to
control the appearance of the router or it may be used by controlling orchestration software
to annotate the router with useful information."
   The field is optional and non-functional (it doesn't affect the operation of the router).
 It's usefulness is completely dictated by the management/control layers over the router.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message