From dev-return-96356-archive-asf-public=cust-asf.ponee.io@qpid.apache.org Tue Jul 23 21:23:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 656D6180676 for ; Tue, 23 Jul 2019 23:23:02 +0200 (CEST) Received: (qmail 14863 invoked by uid 500); 23 Jul 2019 21:23:01 -0000 Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list dev@qpid.apache.org Received: (qmail 14803 invoked by uid 99); 23 Jul 2019 21:23:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2019 21:23:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 79BF1E2EEB for ; Tue, 23 Jul 2019 21:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2A9DC265CF for ; Tue, 23 Jul 2019 21:23:00 +0000 (UTC) Date: Tue, 23 Jul 2019 21:23:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@qpid.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PROTON-2079) Coverity issues related to printf on master branch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PROTON-2079?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 91392#comment-16891392 ]=20 ASF GitHub Bot commented on PROTON-2079: ---------------------------------------- astitcher commented on pull request #185: PROTON-2079: Fix usage of formatt= ing placeholders in printfs URL: https://github.com/apache/qpid-proton/pull/185#discussion_r306539270 =20 =20 ########## File path: c/tools/msgr-send.c ########## @@ -289,7 +289,7 @@ int main(int argc, char** argv) check_messenger(messenger); } =20 - LOG("Messages received=3D%llu sent=3D%llu\n", received, sent); + LOG("Messages received=3D%" PRIu64 " sent=3D%" PRIu64 "\n", received, = sent); =20 Review comment: True, but is that header included? It's internal to proton and (I think)= this is code that only uses the exposed proton API (albeit the old messeng= er API. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Coverity issues related to printf on master branch > -------------------------------------------------- > > Key: PROTON-2079 > URL: https://issues.apache.org/jira/browse/PROTON-2079 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c > Affects Versions: proton-c-0.28.0 > Reporter: Jiri Dan=C4=9Bk > Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org For additional commands, e-mail: dev-help@qpid.apache.org