From dev-return-96330-archive-asf-public=cust-asf.ponee.io@qpid.apache.org Tue Jul 23 15:11:31 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C71D81802C7 for ; Tue, 23 Jul 2019 17:11:30 +0200 (CEST) Received: (qmail 66128 invoked by uid 500); 23 Jul 2019 15:11:30 -0000 Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list dev@qpid.apache.org Received: (qmail 66117 invoked by uid 99); 23 Jul 2019 15:11:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2019 15:11:30 +0000 From: GitBox To: dev@qpid.apache.org Subject: [GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #541: DISPATCH-1389: optimize the STATE_IN_BODY codepath in qd_iterator_octet Message-ID: <156389468484.12027.2930883117736994027.gitbox@gitbox.apache.org> Date: Tue, 23 Jul 2019 15:11:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit kgiusti commented on a change in pull request #541: DISPATCH-1389: optimize the STATE_IN_BODY codepath in qd_iterator_octet URL: https://github.com/apache/qpid-dispatch/pull/541#discussion_r306376031 ########## File path: src/iterator.c ########## @@ -555,8 +555,33 @@ void qd_iterator_annotate_space(qd_iterator_t *iter, const char* space, int spac unsigned char qd_iterator_octet(qd_iterator_t *iter) { - if (!iter) - return 0; + assert(iter); Review comment: yeah, was hoping to save a bit there, but look like the rest of the api verifies the iter pointer, so I'll add it back ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org For additional commands, e-mail: dev-help@qpid.apache.org