qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (QPID-3616) Java Broker misinterprets message.flow infinite credit value (0xFFFFFFFF)
Date Tue, 09 Jul 2019 17:07:00 GMT

     [ https://issues.apache.org/jira/browse/QPID-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rob Godfrey resolved QPID-3616.
-------------------------------
    Resolution: Fixed

> Java Broker misinterprets message.flow infinite credit value (0xFFFFFFFF)
> -------------------------------------------------------------------------
>
>                 Key: QPID-3616
>                 URL: https://issues.apache.org/jira/browse/QPID-3616
>             Project: Qpid
>          Issue Type: Bug
>          Components: Broker-J
>    Affects Versions: 0.13
>            Reporter: Keith Wall
>            Priority: Major
>
> The AMQP 0-10 defines 0xFFFFFFFF as meaning "an infinite amount of credit." as the value
argument to the message.flow command.
> A bug in the Java Broker (WindowCreditManager) means that this value is interpreted literally.
The WCM class should be changed to understand the special value.
> It also appears that notification logic in WindowCreditManager#restoreCredit presently
relies on this defect.  This must be refactored during this change. SubscriptionImpl and Subscription_0_10
appears to contain further workarounds in #creditStateChanged() callback methods.   These
should be reworked too.
> {code}
> if(_state.compareAndSet(State.SUSPENDED, State.ACTIVE))
> {
>     _stateListener.stateChange(this, State.SUSPENDED, State.ACTIVE);
> }
> else
> {
>     // this is a hack to get round the issue of increasing bytes credit
>     _stateListener.stateChange(this, State.ACTIVE, State.ACTIVE);
> }
> {code}
> This defect is unlikely to affect users as 0xFFFFFFFF gives a bytes credit of 4GB or
a message credit limit of more than 4 billion.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message