qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #541: DISPATCH-1389: optimize the STATE_IN_BODY codepath in qd_iterator_octet
Date Tue, 23 Jul 2019 15:11:24 GMT
kgiusti commented on a change in pull request #541: DISPATCH-1389: optimize the STATE_IN_BODY
codepath in qd_iterator_octet
URL: https://github.com/apache/qpid-dispatch/pull/541#discussion_r306376031
 
 

 ##########
 File path: src/iterator.c
 ##########
 @@ -555,8 +555,33 @@ void qd_iterator_annotate_space(qd_iterator_t *iter, const char* space,
int spac
 
 unsigned char qd_iterator_octet(qd_iterator_t *iter)
 {
-    if (!iter)
-        return 0;
+    assert(iter);
 
 Review comment:
   yeah, was hoping to save a bit there, but look like the rest of the api verifies the iter
pointer, so I'll add it back

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message