qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kgiusti commented on a change in pull request #445: DISPATCH-1246: clean up core link endpoints on shutdown
Date Thu, 31 Jan 2019 14:44:12 GMT
kgiusti commented on a change in pull request #445: DISPATCH-1246: clean up core link endpoints
on shutdown
URL: https://github.com/apache/qpid-dispatch/pull/445#discussion_r252694243
 
 

 ##########
 File path: src/router_core/connections.c
 ##########
 @@ -1227,9 +1223,7 @@ static void qdr_connection_closed_CT(qdr_core_t *core, qdr_action_t
*action, boo
     qdr_connection_work_t *work = DEQ_HEAD(conn->work_list);
     while (work) {
         DEQ_REMOVE_HEAD(conn->work_list);
-        qdr_terminus_free(work->source);
-        qdr_terminus_free(work->target);
-        free_qdr_connection_work_t(work);
+        qdr_connection_work_free_CT(work);
 
 Review comment:
   Good catch Chuck!
   
   Did this happen running the unit tests?   I'd like to reproduce it.
   
   -1 this PR until I can fix this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message