qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1984) [c] pn_data_inspect has order n^2 running time
Date Thu, 20 Dec 2018 03:33:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725559#comment-16725559
] 

ASF subversion and git services commented on PROTON-1984:
---------------------------------------------------------

Commit b456360bf26fda5cf787bb1f7cc480bbc5103127 in qpid-proton's branch refs/heads/master
from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=b456360 ]

PROTON-1984: [c] Avoid O(n^2) complexity in pn_data_inspect
- Rework original change to preserve correct stringifying of pn_data_t
- Unfortunately restores some potential O(n^2) behaviour but in many
  fewer cases.

This reverts commit 58ec2b1e54d00fce4a07b7c3c6de2b504b2525ee.


> [c] pn_data_inspect has order n^2 running time
> ----------------------------------------------
>
>                 Key: PROTON-1984
>                 URL: https://issues.apache.org/jira/browse/PROTON-1984
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>            Priority: Major
>             Fix For: proton-c-0.27.0
>
>
> pni_node_index which is used in a couple of places to find out the index of a node inside
a pn_data_t has a run time that is linear in the size of the level of the pn_data_t it is
at.
> pni_inspect_enter and pni_inspect_exit which are called for every node in the pn_data_t
when traversing it using pn_data_inspect use pni_node_index. This means that the overall time
complexity is n^2 in the size of any embedded compound data structure (array, list, map).
> So for large compound data structures this can take an extremely long time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message