qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1946) [cpp] connection config file parser mis-handling TLS defaults
Date Tue, 02 Oct 2018 14:58:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635633#comment-16635633
] 

ASF subversion and git services commented on PROTON-1946:
---------------------------------------------------------

Commit b34215170680ebb2f6b60604374c58f598b45803 in qpid-proton's branch refs/heads/master
from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b342151 ]

PROTON-1946: [cpp] connection config parser incorrect defaults

- Change default "host" to "localhost" (was "")
- Only throw proton::error, don't leak jsoncpp exceptions
- Add tests for SASL/TLS behavior
- Treat explicit "null" valued field as equivalent to a missing field


> [cpp] connection config file parser mis-handling TLS defaults
> -------------------------------------------------------------
>
>                 Key: PROTON-1946
>                 URL: https://issues.apache.org/jira/browse/PROTON-1946
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: proton-c-0.25.0
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>            Priority: Major
>             Fix For: proton-c-0.26.0
>
>
> The C++ connection configuration parser mis-handles default values in several ways:
>  * tls is not enabled unless there is a tls: {} section - it should be enabled (with
default config) if scheme: amqps is present even if there is no tls section
>  * in several cases an explicit 'field: null' is treated differently (as an error) from
field being absent (use default value). null and absent should be equivalent.
>  * Host defaults to "", it should be "localhost"
>  * Some exceptions from jsoncpp are leaked, they should be wrapped in proton::error
>  * Need additional tests to cover all of the above



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message