qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options
Date Thu, 05 Jul 2018 16:17:00 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533865#comment-16533865
] 

Alan Conway commented on PROTON-1703:
-------------------------------------

I think the deprecated macros and comments are sufficient for marking the source code, but
I like Robbie's suggestion of a master Jira. In this case the fix was made and reverted, so
having a link to the Jira gives us the fix to be re-applied. When we get to a breaking release
we can check both the linked Jiras and the source code to make sure we fix everything with
maximum information.

> [cpp] Remove auto_settle from receiver options
> ----------------------------------------------
>
>                 Key: PROTON-1703
>                 URL: https://issues.apache.org/jira/browse/PROTON-1703
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: proton-c-0.19.0
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>            Priority: Minor
>
> auto_settle is a sender-only option, the receiver equivalent is auto_accept.
> auto_settle is only used at messaging_adapter.cpp#L172, which applies only to senders,
it was included in the option list by mistake.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message