qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7153) Allow expired messages to be sent to DLQ
Date Thu, 05 Jul 2018 16:08:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533852#comment-16533852
] 

Rob Godfrey commented on QPID-7153:
-----------------------------------

{noformat}- q -> !((q instanceof AbstractQueue) && ((AbstractQueue) q).wouldExpire(node.getMessage())));

+ q -> !((q instanceof Queue) && wouldExpireNow((Queue)q, node.getMessage())));
{noformat}

This seems wrong to me - you are passing a Queue object which does not define the method to
AbstractQueue which is a particular implementation.  I think the prior version is more correct.

> Allow expired messages to be sent to DLQ
> ----------------------------------------
>
>                 Key: QPID-7153
>                 URL: https://issues.apache.org/jira/browse/QPID-7153
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Keith Wall
>            Priority: Major
>             Fix For: qpid-java-broker-7.1.0
>
>         Attachments: 0002-QPID-7153-Adress-review-comments.patch, QPID-7153v2.diff
>
>
> Currently the Java Broker simply discards messages that expire (TTL). The behaviour should
be configurable and allow for expired messages to be directed to the alternate exchange to
allow for dead-lettering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message