From dev-return-84422-archive-asf-public=cust-asf.ponee.io@qpid.apache.org Tue Jan 9 15:00:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 13D13180718 for ; Tue, 9 Jan 2018 15:00:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 03691160C2D; Tue, 9 Jan 2018 14:00:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EF46D160C13 for ; Tue, 9 Jan 2018 15:00:04 +0100 (CET) Received: (qmail 83691 invoked by uid 500); 9 Jan 2018 14:00:04 -0000 Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list dev@qpid.apache.org Received: (qmail 83680 invoked by uid 99); 9 Jan 2018 14:00:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jan 2018 14:00:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 932FEC4267 for ; Tue, 9 Jan 2018 14:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 8Z7uUcc_wYce for ; Tue, 9 Jan 2018 14:00:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 55DB35FB71 for ; Tue, 9 Jan 2018 14:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5ACA2E0373 for ; Tue, 9 Jan 2018 14:00:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 14CE7240DA for ; Tue, 9 Jan 2018 14:00:00 +0000 (UTC) Date: Tue, 9 Jan 2018 14:00:00 +0000 (UTC) From: "Alojzij Blatnik (JIRA)" To: dev@qpid.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (QPID-8071) Java Qpid library does not report that session was closed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/QPID-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alojzij Blatnik updated QPID-8071: ---------------------------------- Description: when qpid.io_network_transport_timeout is exceeded, qpid-java library does not throw exception, but the exception is just logged, hence the code, that is calling qpid-java library doesn't know that qpid message wasn't sent until it becomes obvious that connection is closed. monkey patch: {{diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java b/common/src/main/java/org/apache/qpid/transport/Session.java index 9568873..b1afd8d 100644 --- a/common/src/main/java/org/apache/qpid/transport/Session.java +++ b/common/src/main/java/org/apache/qpid/transport/Session.java @@ -759,16 +759,7 @@ public class Session extends SessionInvoker } catch (SenderException e) { - if (!closing) - { - // if we are not closing then this will happen - // again on resume - LOGGER.error("error sending command", e); - } - else - { - e.rethrow(); - } + e.rethrow(); } if (autoSync) { }} Some logs: {{ 12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender - write timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail -2147348047 12586 [main] ERROR org.apache.qpid.transport.Session - error sending command org.apache.qpid.transport.SenderException: write timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail -2147348047 at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172) at org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215) at org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149) at org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88) at org.apache.qpid.transport.Connection.flush(Connection.java:428) at org.apache.qpid.transport.Session.send(Session.java:592) at org.apache.qpid.transport.Session.invoke(Session.java:758) at org.apache.qpid.transport.Session.invoke(Session.java:613) at org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93) at org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371) at org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549) at org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333) at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430) at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391) at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497) at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483) at tld.domain.OurLibrary.send(OurLibrary.java:373) at tld.domain.Main.send(Main.java:476) at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285) at tld.domain.MainAttict.main(MainAttict.java:368) 12589 [main] INFO tld.domain.MainAttict - message sent 12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR org.apache.qpid.client.AMQConnectionDelegate_0_10 - connection exception: conn:70d0de44 org.apache.qpid.transport.ConnectionException: connection aborted at org.apache.qpid.transport.Connection.closed(Connection.java:574) at org.apache.qpid.transport.network.Assembler.closed(Assembler.java:115) at org.apache.qpid.transport.network.InputHandler.closed(InputHandler.java:221) at org.apache.qpid.transport.network.security.ssl.SSLReceiver.closed(SSLReceiver.java:69) at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:225) at java.lang.Thread.run(Thread.java:745) 12590 [main] INFO tld.domain.OurLibrary - lock for qpid connection status is not defined, hence it won't be created. Status: connection lost }} was: when qpid.io_network_transport_timeout is exceeded, qpid-java library does not throw exception, but the exception is just logged, hence the code, that is calling qpid-java library doesn't know that qpid message wasn't sent until it becomes obvious that connection is closed. monkey patch: ``` diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java b/common/src/main/java/org/apache/qpid/transport/Session.java index 9568873..b1afd8d 100644 --- a/common/src/main/java/org/apache/qpid/transport/Session.java +++ b/common/src/main/java/org/apache/qpid/transport/Session.java @@ -759,16 +759,7 @@ public class Session extends SessionInvoker } catch (SenderException e) { - if (!closing) - { - // if we are not closing then this will happen - // again on resume - LOGGER.error("error sending command", e); - } - else - { - e.rethrow(); - } + e.rethrow(); } if (autoSync) { ``` Some logs: ``` 12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender - write timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail -2147348047 12586 [main] ERROR org.apache.qpid.transport.Session - error sending command org.apache.qpid.transport.SenderException: write timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail -2147348047 at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172) at org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215) at org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149) at org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88) at org.apache.qpid.transport.Connection.flush(Connection.java:428) at org.apache.qpid.transport.Session.send(Session.java:592) at org.apache.qpid.transport.Session.invoke(Session.java:758) at org.apache.qpid.transport.Session.invoke(Session.java:613) at org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93) at org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371) at org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549) at org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333) at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430) at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391) at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497) at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483) at tld.domain.OurLibrary.send(OurLibrary.java:373) at tld.domain.Main.send(Main.java:476) at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285) at tld.domain.MainAttict.main(MainAttict.java:368) 12589 [main] INFO tld.domain.MainAttict - message sent 12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR org.apache.qpid.client.AMQConnectionDelegate_0_10 - connection exception: conn:70d0de44 org.apache.qpid.transport.ConnectionException: connection aborted at org.apache.qpid.transport.Connection.closed(Connection.java:574) at org.apache.qpid.transport.network.Assembler.closed(Assembler.java:115) at org.apache.qpid.transport.network.InputHandler.closed(InputHandler.java:221) at org.apache.qpid.transport.network.security.ssl.SSLReceiver.closed(SSLReceiver.java:69) at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:225) at java.lang.Thread.run(Thread.java:745) 12590 [main] INFO tld.domain.OurLibrary - lock for qpid connection status is not defined, hence it won't be created. Status: connection lost ``` > Java Qpid library does not report that session was closed > --------------------------------------------------------- > > Key: QPID-8071 > URL: https://issues.apache.org/jira/browse/QPID-8071 > Project: Qpid > Issue Type: Bug > Components: Broker-J > Affects Versions: qpid-java-6.1.5 > Environment: slow network towards Qpid broker > Reporter: Alojzij Blatnik > > when qpid.io_network_transport_timeout is exceeded, qpid-java library does not throw exception, but the exception is just logged, hence the code, that is calling qpid-java library doesn't know that qpid message wasn't sent until it becomes obvious that connection is closed. > monkey patch: > {{diff --git a/common/src/main/java/org/apache/qpid/transport/Session.java b/common/src/main/java/org/apache/qpid/transport/Session.java > index 9568873..b1afd8d 100644 > --- a/common/src/main/java/org/apache/qpid/transport/Session.java > +++ b/common/src/main/java/org/apache/qpid/transport/Session.java > @@ -759,16 +759,7 @@ public class Session extends SessionInvoker > } > catch (SenderException e) > { > - if (!closing) > - { > - // if we are not closing then this will happen > - // again on resume > - LOGGER.error("error sending command", e); > - } > - else > - { > - e.rethrow(); > - } > + e.rethrow(); > } > if (autoSync) > { > }} > Some logs: > {{ > 12585 [main] ERROR org.apache.qpid.transport.network.io.IoSender - write timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail -2147348047 > 12586 [main] ERROR org.apache.qpid.transport.Session - error sending command > org.apache.qpid.transport.SenderException: write timed out for socket /172.21.0.2:50618-qpid-broker/192.168.80.1:5671: head -2147216975, tail -2147348047 > at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:172) > at org.apache.qpid.transport.network.security.ssl.SSLSender.doSend(SSLSender.java:215) > at org.apache.qpid.transport.network.security.ssl.SSLSender.flush(SSLSender.java:149) > at org.apache.qpid.transport.network.Disassembler.flush(Disassembler.java:88) > at org.apache.qpid.transport.Connection.flush(Connection.java:428) > at org.apache.qpid.transport.Session.send(Session.java:592) > at org.apache.qpid.transport.Session.invoke(Session.java:758) > at org.apache.qpid.transport.Session.invoke(Session.java:613) > at org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:93) > at org.apache.qpid.client.BasicMessageProducer_0_10.sendMessage(BasicMessageProducer_0_10.java:371) > at org.apache.qpid.client.BasicMessageProducer.sendImpl(BasicMessageProducer.java:549) > at org.apache.qpid.client.BasicMessageProducer.send(BasicMessageProducer.java:333) > at tld.domain.OurLibrary$SendLogic.sendLogic(OurLibrary.java:430) > at tld.domain.OurLibrary$SendLogic.run(OurLibrary.java:391) > at tld.domain.OurLibrary.reconnectCommonLogic(OurLibrary.java:497) > at tld.domain.OurLibrary.reconnectLogic(OurLibrary.java:483) > at tld.domain.OurLibrary.send(OurLibrary.java:373) > at tld.domain.Main.send(Main.java:476) > at tld.domain.MainAttict.tesSendMsg(MainAttict.java:285) > at tld.domain.MainAttict.main(MainAttict.java:368) > 12589 [main] INFO tld.domain.MainAttict - message sent > 12590 [IoRcvr-/172.21.0.2:50618-qpid-broker/192.168.80.1:5671] ERROR org.apache.qpid.client.AMQConnectionDelegate_0_10 - connection exception: conn:70d0de44 > org.apache.qpid.transport.ConnectionException: connection aborted > at org.apache.qpid.transport.Connection.closed(Connection.java:574) > at org.apache.qpid.transport.network.Assembler.closed(Assembler.java:115) > at org.apache.qpid.transport.network.InputHandler.closed(InputHandler.java:221) > at org.apache.qpid.transport.network.security.ssl.SSLReceiver.closed(SSLReceiver.java:69) > at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:225) > at java.lang.Thread.run(Thread.java:745) > 12590 [main] INFO tld.domain.OurLibrary - lock for qpid connection status is not defined, hence it won't be created. Status: connection lost > }} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org For additional commands, e-mail: dev-help@qpid.apache.org