qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gordon Sim <g...@redhat.com>
Subject Re: dispatch tests failing (Re: [1/2] qpid-proton git commit: PROTON-1727 [epoll] fix file descriptor leak on reconnect)
Date Mon, 15 Jan 2018 20:17:57 GMT
On 12/01/18 21:54, Gordon Sim wrote:
> On 10/01/18 10:19, Gordon Sim wrote:
>> I see two if the dispatch system tests failing after the following 
>> commit to proton (they all when run against a proton lib before this 
>> patch). Subsequent commits to proton don't help either - dispatch 
>> tests fail against latest proton master also.
>> The tests that fail are system_tests_user_id_proxy and 
>> system_tests_policy.
> The problem I believe is that this change moves the retrieval of the 
> remote address from pconnection_start to pconnection_connected_lh and 
> this means that when the router tries to get the hostname for the 
> connection (to do policy checks) in the connection_bound event, it 
> hasn't yet been retrieved.
> I don't really understand the issue this change is trying to fix, so not 
> sure how best to address the issue yet. Any ideas?

Fyi: I committed a fix for this (see DISPATCH-912 if interested).

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message