Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@qpid.apache.org
From: kgiusti <git@git.apache.org>
To: dev@qpid.apache.org
Reply-To: dev@qpid.apache.org
References: <git-pr-218-qpid-dispatch@git.apache.org>
In-Reply-To: <git-pr-218-qpid-dispatch@git.apache.org>
Subject: [GitHub] qpid-dispatch pull request #218: DISPATCH-875 - Doc new "pattern" attribute ...
Content-Type: text/plain
Message-Id: <20171115154956.34BF3DFF58@git1-us-west.apache.org>
Date: Wed, 15 Nov 2017 15:49:56 +0000 (UTC)
archived-at: Wed, 15 Nov 2017 15:49:58 -0000

Github user kgiusti commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/218#discussion_r151165869
  
    --- Diff: doc/new-book/routing.adoc ---
    @@ -213,11 +213,30 @@ address {
     }
     ----
     
    -`prefix`:: The address prefix. All messages that match this prefix will be distributed according to the distribution pattern you specify.
    +`prefix` | `pattern`:: The address or group of addresses to which the address settings should be applied. You can specify a prefix to match an exact address or segment of an address. Alternatively, you can specify a pattern to match an address using wildcards.
    --- End diff --
    
    When describing the 'prefix' match I would avoid using the unqualified term 'segment' in favor of something like 'beginning segment'.   In other words:
    
    'match an exact address or **beginning segment** of an address'
    
    I'd apply that to all the other prefix descriptions throughout the doc.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org