qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request 23130: Removing wrapped types from proton swigged bindings
Date Fri, 27 Jun 2014 19:12:07 GMT


> On June 27, 2014, 7:10 p.m., Darryl Pierce wrote:
> > proton/trunk/proton-c/bindings/python/cproton.i, line 40
> > <https://reviews.apache.org/r/23130/diff/1/?file=619420#file619420line40>
> >
> >     These methods are used by the Ruby and Perl bindings.

I know - that's why I only removed them from the python binding!


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23130/#review46895
-----------------------------------------------------------


On June 27, 2014, 5:06 p.m., Andrew Stitcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23130/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 5:06 p.m.)
> 
> 
> Review request for qpid and Darryl Pierce.
> 
> 
> Bugs: PROTON-620
>     https://issues.apache.org/jira/browse/PROTON-620
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> see PROTON-620 for rationale.
> 
> Note that this also has a bug fix which stops python crashing when trying to typemap
non strings to pn_uuid_t
> 
> 
> Diffs
> -----
> 
>   proton/trunk/proton-c/bindings/python/cproton.i 1606140 
>   proton/trunk/proton-c/bindings/ruby/ruby.i 1606140 
>   proton/trunk/proton-c/include/proton/cproton.i 1606140 
> 
> Diff: https://reviews.apache.org/r/23130/diff/
> 
> 
> Testing
> -------
> 
> ctest succeeds for all languages that have tests.
> 
> 
> Thanks,
> 
> Andrew Stitcher
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message