qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Schloming" <...@apache.org>
Subject Re: Review Request 23122: Proton map/hash entries can disappear
Date Fri, 27 Jun 2014 10:56:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23122/#review46849
-----------------------------------------------------------


The fix looks good, but it would be nice to see a test case for this. The file src/tests/object.c
has a bunch of tests. I'm thinking if you define an object type with a very simple hash, e.g.
a string-like object type that always hashes to the first character of the string, then it
should be easy to create collisions and reproduce this situation. I think you could do that
by just creating a second pn_class_t for string and just override the hash function.

- Rafael Schloming


On June 27, 2014, 7:24 a.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23122/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 7:24 a.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Bugs: PROTON-617
>     https://issues.apache.org/jira/browse/PROTON-617
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> The proposed fix tests for the case of being the first link in a multipart chain and
copies the second entry over top and makes the old location of the second entry available
for reuse.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/object/object.c 1605943

> 
> Diff: https://reviews.apache.org/r/23122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message