Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@qpid.apache.org
Content-Type: multipart/alternative;
 boundary="===============1208705931085058662=="
MIME-Version: 1.0
Subject: Re: Review Request 16316: Implement control of internal logging in
 qpid::messaging API
From: "Chug Rolke" <crolke@redhat.com>
To: "Chug Rolke" <crolke@redhat.com>, "Gordon Sim" <gsim@redhat.com>
Cc: "Andrew Stitcher" <astitcher@apache.org>, "qpid" <dev@qpid.apache.org>
Date: Fri, 03 Jan 2014 15:03:26 -0000
Message-ID: <20140103150326.29218.9952@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Chug Rolke" <noreply@reviews.apache.org>
References: <20140103054805.26158.83100@reviews.apache.org>
In-Reply-To: <20140103054805.26158.83100@reviews.apache.org>
Reply-To: "Chug Rolke" <crolke@redhat.com>

--===============1208705931085058662==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16316/#review31132
-----------------------------------------------------------

Ship it!


Various bindings need similar additions in order for the logging control to be exposed to the ultimate end user.


- Chug Rolke


On Jan. 3, 2014, 5:48 a.m., Andrew Stitcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16316/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 5:48 a.m.)
> 
> 
> Review request for qpid, Chug Rolke and Gordon Sim.
> 
> 
> Bugs: QPID-5415
>     https://issues.apache.org/jira/browse/QPID-5415
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Currently there is one major omission from the qpid::messaging API: That is control of the internal logging used by qpid itself.
> 
> This was previously present in the qpid::client API albeit not really supported or documented. Now that we have completely removed the qpid::client and associated APIs from being exported for use beyond qpid itself there is no way to control the logging internal to the qpid messaging libraries.
> 
> This review introduces some simple APIs which give back control of the qpid's internal logging. I think there is now as much control as virtually all qpid user applications are likely to need.
> 
> Please give the proposed API some consideration and let me know if there is anything that an application needs that I haven't considered here.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/include/qpid/messaging/Logger.h PRE-CREATION 
>   /trunk/qpid/cpp/src/CMakeLists.txt 1551620 
>   /trunk/qpid/cpp/src/qpid/log/Logger.cpp 1551620 
>   /trunk/qpid/cpp/src/qpid/log/Options.h 1551620 
>   /trunk/qpid/cpp/src/qpid/log/Options.cpp 1551620 
>   /trunk/qpid/cpp/src/qpid/log/Selector.cpp 1551620 
>   /trunk/qpid/cpp/src/qpid/log/Statement.h 1551620 
>   /trunk/qpid/cpp/src/qpid/log/Statement.cpp 1551620 
>   /trunk/qpid/cpp/src/qpid/messaging/Logger.cpp PRE-CREATION 
>   /trunk/qpid/cpp/src/tests/CMakeLists.txt 1551620 
>   /trunk/qpid/cpp/src/tests/MessagingLogger.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16316/diff/
> 
> 
> Testing
> -------
> 
> Added in unit tests which pass*
> 
> *They currently also assume a bug fix which is included in the code in this review which prevents critical log messages ever being turned off (I think this the correct behaviour - in the current code under some circumstances they can actually be turned off)
> 
> 
> Thanks,
> 
> Andrew Stitcher
> 
>


--===============1208705931085058662==--