Return-Path: X-Original-To: apmail-qpid-dev-archive@www.apache.org Delivered-To: apmail-qpid-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F3BBB10564 for ; Fri, 3 Jan 2014 14:13:38 +0000 (UTC) Received: (qmail 38681 invoked by uid 500); 3 Jan 2014 14:13:37 -0000 Delivered-To: apmail-qpid-dev-archive@qpid.apache.org Received: (qmail 38642 invoked by uid 500); 3 Jan 2014 14:13:33 -0000 Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list dev@qpid.apache.org Received: (qmail 38620 invoked by uid 99); 3 Jan 2014 14:13:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jan 2014 14:13:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8C2BC1D35D7; Fri, 3 Jan 2014 14:13:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3139777449315965001==" MIME-Version: 1.0 Subject: Re: Review Request 16577: QPID-5428: Heartbeats not in use when attempting to connect with python client. From: "Alan Conway" To: "Rafael Schloming" , "Gordon Sim" Cc: "Andrew Stitcher" , "Alan Conway" , "qpid" Date: Fri, 03 Jan 2014 14:13:28 -0000 Message-ID: <20140103141328.29218.25227@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alan Conway" X-ReviewGroup: qpid X-ReviewRequest-URL: https://reviews.apache.org/r/16577/ X-Sender: "Alan Conway" References: <20140103002244.26158.67096@reviews.apache.org> In-Reply-To: <20140103002244.26158.67096@reviews.apache.org> Reply-To: "Alan Conway" X-ReviewRequest-Repository: qpid --===============3139777449315965001== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Jan. 3, 2014, 12:22 a.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/tests/ha_tests.py, line 237 > > > > > > This doesn't appear to be an HA test why is it in these tests? Agreed, should be in the qpid/python tests somewhere. I'll look for an appropriate place. > On Jan. 3, 2014, 12:22 a.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/tests/ha_tests.py, line 243 > > > > > > I don't see anywhere that you send SIGCONT to the broker to get it to carry on - how do subsequent tests work? The brokertest framework automatically tears down processes (including brokers) started by each test, each test starts new brokers as needed. - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16577/#review31093 ----------------------------------------------------------- On Jan. 2, 2014, 10:15 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16577/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 10:15 p.m.) > > > Review request for qpid, Gordon Sim and Rafael Schloming. > > > Bugs: qpid-5428 > https://issues.apache.org/jira/browse/qpid-5428 > > > Repository: qpid > > > Description > ------- > > QPID-5428: Heartbeats not in use when attempting to connect with python client. > > The heartbeat setting was ignored when opening a connection, so opening a > connection could hang indefinitely unless a timeout was set. > > The fix is to set the timeout to 2x heartbeat if a heartbeat interval is set. > > > Diffs > ----- > > /trunk/qpid/cpp/src/tests/ha_tests.py 1554805 > /trunk/qpid/python/qpid/messaging/endpoints.py 1554805 > > Diff: https://reviews.apache.org/r/16577/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > > --===============3139777449315965001==--