qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 16577: QPID-5428: Heartbeats not in use when attempting to connect with python client.
Date Fri, 03 Jan 2014 14:13:35 GMT


> On Jan. 3, 2014, 10:01 a.m., Gordon Sim wrote:
> > /trunk/qpid/python/qpid/messaging/endpoints.py, line 70
> > <https://reviews.apache.org/r/16577/diff/1/?file=413696#file413696line70>
> >
> >     The problem with this is that it only works for calls to Connection.establish().
If you do a con.open() directly, then you may hang until the socket itself timesout.
> >     
> >     In Connection.open() there is a similar use of reconnect_timeout to set the
timeout on the attach. So even with the above logic moved there, there would be some confusion
between those parameters.
> >     
> >     My final concern is on reconnect. I don't believe the open() timeout will have
any effect there.

Good points, I'll review the solution.


- Alan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16577/#review31118
-----------------------------------------------------------


On Jan. 2, 2014, 10:15 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16577/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2014, 10:15 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Rafael Schloming.
> 
> 
> Bugs: qpid-5428
>     https://issues.apache.org/jira/browse/qpid-5428
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> QPID-5428: Heartbeats not in use when attempting to connect with python client.
> 
> The heartbeat setting was ignored when opening a connection, so opening a
> connection could hang indefinitely unless a timeout was set.
> 
> The fix is to set the timeout to 2x heartbeat if a heartbeat interval is set.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/tests/ha_tests.py 1554805 
>   /trunk/qpid/python/qpid/messaging/endpoints.py 1554805 
> 
> Diff: https://reviews.apache.org/r/16577/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message