qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Review Request 16577: QPID-5428: Heartbeats not in use when attempting to connect with python client.
Date Thu, 02 Jan 2014 22:15:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16577/
-----------------------------------------------------------

Review request for qpid, Gordon Sim and Rafael Schloming.


Bugs: qpid-5428
    https://issues.apache.org/jira/browse/qpid-5428


Repository: qpid


Description
-------

QPID-5428: Heartbeats not in use when attempting to connect with python client.

The heartbeat setting was ignored when opening a connection, so opening a
connection could hang indefinitely unless a timeout was set.

The fix is to set the timeout to 2x heartbeat if a heartbeat interval is set.


Diffs
-----

  /trunk/qpid/cpp/src/tests/ha_tests.py 1554805 
  /trunk/qpid/python/qpid/messaging/endpoints.py 1554805 

Diff: https://reviews.apache.org/r/16577/diff/


Testing
-------


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message