Return-Path: X-Original-To: apmail-qpid-dev-archive@www.apache.org Delivered-To: apmail-qpid-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD13410B27 for ; Wed, 2 Oct 2013 11:38:43 +0000 (UTC) Received: (qmail 96793 invoked by uid 500); 2 Oct 2013 11:38:43 -0000 Delivered-To: apmail-qpid-dev-archive@qpid.apache.org Received: (qmail 96237 invoked by uid 500); 2 Oct 2013 11:38:42 -0000 Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list dev@qpid.apache.org Received: (qmail 95864 invoked by uid 99); 2 Oct 2013 11:38:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2013 11:38:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2881A1D3161; Wed, 2 Oct 2013 11:38:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1111511031998647242==" MIME-Version: 1.0 Subject: Review Request 14442: Check length of error description before assigning to size limited buffer From: "Gordon Sim" To: "Rafael Schloming" Cc: "Gordon Sim" , "qpid" Date: Wed, 02 Oct 2013 11:38:35 -0000 Message-ID: <20131002113835.28588.99629@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gordon Sim" X-ReviewGroup: qpid X-ReviewRequest-URL: https://reviews.apache.org/r/14442/ X-Sender: "Gordon Sim" Reply-To: "Gordon Sim" --===============1111511031998647242== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14442/ ----------------------------------------------------------- Review request for qpid and Rafael Schloming. Bugs: PROTON-432 https://issues.apache.org/jira/browse/PROTON-432 Repository: qpid Description ------- If error description is very long it overruns the buffer and causes segfault on processing the corrupted condition information. Diffs ----- /proton/trunk/proton-c/src/transport/transport.c 1527976 Diff: https://reviews.apache.org/r/14442/diff/ Testing ------- Fixes my test case Thanks, Gordon Sim --===============1111511031998647242==--