qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request 14443: Build Amqp1.0 support into QpidMessaging for all platforms
Date Thu, 03 Oct 2013 18:48:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14443/
-----------------------------------------------------------

(Updated Oct. 3, 2013, 6:48 p.m.)


Review request for qpid and Andrew Stitcher.


Changes
-------

Disable export of AMQPC in test_env.
Disable import and use of AMQPC in brokertest and interlink_tests.
Disable use of AMQPC in swig_python_tests; only run amqp1.0 test if broker has loaded AMQP_LIB.


Bugs: QPID-5115
    https://issues.apache.org/jira/browse/QPID-5115


Repository: qpid


Description
-------

This patch removes the amqpc library and builds Amqp1.0 support into qpidmessaging. Amqp1.0
support is immediately available to clients without loading extra modules.

Amqp1.0 support for clients is controlled by setting the {protocol:amqp1.0} connection option.
Amqp1.0 support for the broker is still isolated in the ampq library. The broker may run with
or without Ampq1.0 support by loading or not loading the amqp library.


Diffs (updated)
-----

  trunk/qpid/cpp/bld-winsdk.ps1 1528551 
  trunk/qpid/cpp/src/CMakeLists.txt 1528551 
  trunk/qpid/cpp/src/amqp.cmake 1528551 
  trunk/qpid/cpp/src/tests/brokertest.py 1528551 
  trunk/qpid/cpp/src/tests/interlink_tests.py 1528551 
  trunk/qpid/cpp/src/tests/swig_python_tests 1528551 
  trunk/qpid/cpp/src/tests/test_env.sh.in 1528551 

Diff: https://reviews.apache.org/r/14443/diff/


Testing
-------

Windows and Linux clients may create Amqp 0.10 and 1.0 connections without setting any environment
variables.
make test passes all tests.


Thanks,

Chug Rolke


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message