qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Schloming" <...@apache.org>
Subject Re: Review Request 13690: Windows cmake tries to install two copies of proton-api.jar
Date Wed, 21 Aug 2013 15:25:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13690/#review25371
-----------------------------------------------------------

Ship it!


Ship It!

- Rafael Schloming


On Aug. 20, 2013, 9:29 p.m., Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13690/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 9:29 p.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Bugs: PROTON-405
>     https://issues.apache.org/jira/browse/PROTON-405
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Cmake 2.8.6 on Windows gets confused installing both versioned and unversioned jar files
with a soft link between them. The cmake code for proton-api is repeated for other java artifacts
and needs attention beyond just proton-api.jar.
> 
> This patch dodges the issue by adding a cmake command line option GEN_JAVA. By default
this option is on and java artifacts are generated normally.
> A user may specify "cmake -DGEN_JAVA=No" to skip generating java artifacts.
> 
> 
> Diffs
> -----
> 
>   proton/trunk/CMakeLists.txt 1515971 
> 
> Diff: https://reviews.apache.org/r/13690/diff/
> 
> 
> Testing
> -------
> 
> works for me
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message