qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 13195: data-dir options in config file is ignored due to bug in init file
Date Mon, 05 Aug 2013 14:01:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13195/#review24645
-----------------------------------------------------------

Ship it!


Ship It!

- Alan Conway


On Aug. 1, 2013, 9:05 p.m., Ernie Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13195/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 9:05 p.m.)
> 
> 
> Review request for qpid and Alan Conway.
> 
> 
> Bugs: 5035
>     https://issues.apache.org/jira/browse/5035
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Patch from Zdenek Kraus for https://bugzilla.redhat.com/show_bug.cgi?id=990972
> The problem is that the qpidd init.d script is always setting the --data-dir command
line argument. This overrides any entries in the qpidd.conf file. 
> 
> The patch adds the --data-dir to the command line only if the QPID_DATA_DIR environment
variable is set
> 
> Note: The original patch was modified to account for a newer version of the qpid/cpp/etc/qpidd.in
file.
> 
> I asked Alan to review because he was the last to modify the qpidd.in file.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/etc/qpidd.in 1509413 
> 
> Diff: https://reviews.apache.org/r/13195/diff/
> 
> 
> Testing
> -------
> 
> - Applied modified patch to /etc/rc.d/init.d/qpidd
> - Added data-dir=/var/lib/qpidd/data-config to /etc/qpid/qpidd.conf
> - Added trace=yes to qpidd.conf
> - Restarted qpidd service
> - Inspected qpidd log files to ensure data-dir from config file was being used
> 
> Found the following line in the log:
> [Store] notice Store module initialized; store-dir=/var/lib/qpidd/data-config
> 
> 
> Thanks,
> 
> Ernie Allen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message