qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request: Keeps track of Qpid runnable threads and other threads, ensuring that rundown doesn't deadlock.
Date Wed, 06 Jul 2011 15:06:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/987/#review965
-----------------------------------------------------------

Ship it!


Cliff,

Thanks for your effort on this.

Without this patch test cases would deadlock under NUnit probably the same as under Excel.
With the patch the test cases exit and NUnit is happy.

-Chuck

- Chug


On 2011-07-05 17:54:17, Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/987/
> -----------------------------------------------------------
> 
> (Updated 2011-07-05 17:54:17)
> 
> 
> Review request for qpid.
> 
> 
> Summary
> -------
> 
> This is the same logic as the preceding version with naming fixes and refinements to
DLL cleanup.
> 
> Cleanup now uses Windows DllMain function to allows cleanup after C++ runtime static
destructors.
> 
> 
> This addresses bug qpid-3256.
>     https://issues.apache.org/jira/browse/qpid-3256
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/sys/windows/Thread.cpp 1143151 
> 
> Diff: https://reviews.apache.org/r/987/diff
> 
> 
> Testing
> -------
> 
> Qpid cmake run_tests
> 
> 
> Thanks,
> 
> Cliff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message