Mailing-List: contact dev-help@qpid.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@qpid.apache.org
Message-ID: <19710607.149691284365732386.JavaMail.jira@thor>
Date: Mon, 13 Sep 2010 04:15:32 -0400 (EDT)
From: =?utf-8?Q?Pawe=C5=82_Krze=C5=9Bniak_=28JIRA=29?=
 <qpid-dev@incubator.apache.org>
To: qpid-dev@incubator.apache.org
Subject: [jira] Commented: (QPID-2405) SASL<->Ruby binding can cause
 seg_faults
In-Reply-To: <1552820841.240861266011548369.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/QPID-2405?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12908=
664#action_12908664 ]=20

Pawe=C5=82 Krze=C5=9Bniak commented on QPID-2405:
---------------------------------------

I can confirm that bug exists. Invoiking inspect method on Connection or Br=
oker ends up with segfault:
---
$ ruby -e 'require "qpid"; s=3DQpid::Qmf::Session.new(); b=3Ds.add_broker; =
puts b.inspect'
-e:1: [BUG] Segmentation fault
ruby 1.8.7 (2009-12-24 patchlevel 248) [i686-linux], MBARI 0x8770, Ruby Ent=
erprise Edition 2010.01

Aborted
---
And I can confirm that Sam's patch fixes the problem.

> SASL<->Ruby binding can cause seg_faults
> ----------------------------------------
>
>                 Key: QPID-2405
>                 URL: https://issues.apache.org/jira/browse/QPID-2405
>             Project: Qpid
>          Issue Type: Bug
>          Components: Ruby Client
>    Affects Versions: 0.5
>         Environment: Ubuntu, ruby 1.8.7, qpid 0.5
>            Reporter: Sam Hendley
>            Assignee: Ted Ross
>             Fix For: 0.5
>
>         Attachments: sasl.patch
>
>
> There is an issue with the sasl bindings where it returns a raw ruby VALU=
E type for the sasl context. This works _UNTIL_ the ruby runtime tries to a=
ccess that variable which then causes a segfault.=20
> This is easy to see if you try to inspect the variable at all (like print=
 it or ask for its class or methods). In my application, for reasons I have=
n't determined yet, just having this variable on the heap meant that when a=
n exception occurred trying to print the exceptions message caused a seg fa=
ult.=20
> In any case, passing back raw VALUEs to ruby code is a Bad Idea and goes =
against the spec. There is a simple macro and fix for this which wraps the =
returned value in a ruby object. This fixes the issue I was having and mean=
s the deleting of the object is done automatically (instead of having a man=
ual free function).
> I have a patch with the simple, low impact fix, really it would be better=
 to the extension so the sasl client is repersented as a real ruby object b=
ut that would require atleast some client code changes.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org