qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Godfrey <rob.j.godf...@gmail.com>
Subject Re: 0-10 Session Close and Failover
Date Thu, 05 Aug 2010 08:41:41 GMT
[snip]

>
> Any objections if I commit the patch below?
>
> As far as I can see it will not result in any difference on the client side
> (it doesn't alter the value of the expiry variable) and given the recent
> change to the broker won't affect the broker on trunk either (which will
> assume a timeout of 0 regardless of the requested value).
>
> Index: java/common/src/main/java/org/apache/qpid/transport/Session.java
> ===================================================================
> --- java/common/src/main/java/org/apache/qpid/transport/Session.java
> (revision 982137)
> +++ java/common/src/main/java/org/apache/qpid/transport/Session.java
> (working copy)
> @@ -237,7 +237,7 @@
>     {
>         initReceiver();
>         sessionAttach(name.getBytes());
> -        sessionRequestTimeout(expiry);
> +        sessionRequestTimeout(0);//use expiry here only if/when session
> resume is supported
>     }
>
>     void resume()
>

I think this patch makes perfect sense, so no objections from my side

-- Rob

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message