qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aidan Skinner <ai...@apache.org>
Subject Re: Remove printStackTrace from client and common
Date Tue, 10 Nov 2009 13:13:40 GMT
On Tue, Nov 10, 2009 at 3:40 AM, Robert Godfrey <rob.j.godfrey@gmail.com> wrote:

> Hi Aidan,
>
> Why did you remove the setting of the linked exception here:

Slippy fingers and tired eyes while looking at the diff. I'll put it back. :)

> Also, we probably want to communicate the stack trace somehow in
>
> ---
> a/qpid/java/client/src/test/java/org/apache/qpid/client/protocol/AMQProtocolHandlerTest.java
> +++
> b/qpid/java/client/src/test/java/org/apache/qpid/client/protocol/AMQProtocolHandlerTest.java
> @@ -178,7 +178,6 @@ public class AMQProtocolHandlerTest extends TestCase
>                 }
>                 catch (Exception e)
>                 {
> -                    e.printStackTrace();
>                     fail(e.getMessage());
>                 }
>             }
>
> although I would think that just not catching the exception here would
> probably do it...

Yeah, not catching is probably the right thing to do there.

- Aidan
-- 
Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
"A witty saying proves nothing" - Voltaire

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message