Return-Path: Delivered-To: apmail-incubator-qpid-dev-archive@locus.apache.org Received: (qmail 27555 invoked from network); 3 Dec 2007 13:36:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Dec 2007 13:36:07 -0000 Received: (qmail 95520 invoked by uid 500); 3 Dec 2007 13:35:53 -0000 Delivered-To: apmail-incubator-qpid-dev-archive@incubator.apache.org Received: (qmail 95480 invoked by uid 500); 3 Dec 2007 13:35:53 -0000 Mailing-List: contact qpid-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: qpid-dev@incubator.apache.org Delivered-To: mailing list qpid-dev@incubator.apache.org Received: (qmail 95471 invoked by uid 99); 3 Dec 2007 13:35:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2007 05:35:53 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2007 13:35:40 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 0CDE8714208 for ; Mon, 3 Dec 2007 05:35:43 -0800 (PST) Message-ID: <24785541.1196688943040.JavaMail.jira@brutus> Date: Mon, 3 Dec 2007 05:35:43 -0800 (PST) From: "Martin Ritchie (JIRA)" To: qpid-dev@incubator.apache.org Subject: [jira] Resolved: (QPID-635) Blocking/Specific MethodFrameListener do not implement equals In-Reply-To: <32970518.1192101830564.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/QPID-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Ritchie resolved QPID-635. --------------------------------- Resolution: Invalid Fix Version/s: (was: M2) M2.1 This is not a problem. SVN commit on M2 has been reverted for M2.1. While the change was correct there was no need as object equality is suitable in this case. > Blocking/Specific MethodFrameListener do not implement equals > ------------------------------------------------------------- > > Key: QPID-635 > URL: https://issues.apache.org/jira/browse/QPID-635 > Project: Qpid > Issue Type: Bug > Affects Versions: M2, M2.1, M3 > Reporter: Martin Ritchie > Assignee: Martin Ritchie > Fix For: M2.1 > > > As these classes do not implement equals() the remove() call on the _framelisteners just grabs the first instance of the class. This is removing the wrong objects from the list. > This means that the new listener is not being notified while the first notifier that has been notified is left in the list. > The result can be seen in a number of tests timing out as there are multiple channels closing and only one is being notified of the returning closeok frame. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.