qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kgiu...@apache.org
Subject [qpid-dispatch] branch master updated: DISPATCH-1247: fix minor bitmask leak
Date Thu, 24 Jan 2019 15:47:09 GMT
This is an automated email from the ASF dual-hosted git repository.

kgiusti pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git


The following commit(s) were added to refs/heads/master by this push:
     new 5785683  DISPATCH-1247: fix minor bitmask leak
5785683 is described below

commit 5785683387f85adb58299b2104def41bf1cb049e
Author: Kenneth Giusti <kgiusti@apache.org>
AuthorDate: Fri Jan 18 11:00:27 2019 -0500

    DISPATCH-1247: fix minor bitmask leak
    
    This closes #442
---
 src/router_node.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/router_node.c b/src/router_node.c
index 8c44264..2402abe 100644
--- a/src/router_node.c
+++ b/src/router_node.c
@@ -513,6 +513,7 @@ static bool AMQP_rx_handler(void* context, qd_link_t *link)
         pn_delivery_update(pnd, PN_RELEASED);
         pn_delivery_settle(pnd);
         qd_message_free(msg);
+        qd_bitmask_free(link_exclusions);
         return next_delivery;
     }
 
@@ -589,8 +590,6 @@ static bool AMQP_rx_handler(void* context, qd_link_t *link)
         delivery = qdr_link_deliver(rlink, msg, ingress_iter, pn_delivery_settled(pnd), link_exclusions,
ingress_index);
     }
 
-
-
     if (delivery) {
         //
         // Settle the proton delivery only if all the data has arrived
@@ -609,6 +608,7 @@ static bool AMQP_rx_handler(void* context, qd_link_t *link)
         //
         // If there is no delivery, the message is now and will always be unroutable because
there is no address.
         //
+        qd_bitmask_free(link_exclusions);
         qd_message_set_discard(msg, true);
         pn_link_flow(pn_link, 1);
         pn_delivery_update(pnd, PN_REJECTED);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message