From commits-return-47700-archive-asf-public=cust-asf.ponee.io@qpid.apache.org Mon Dec 24 02:07:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EE820180608 for ; Mon, 24 Dec 2018 02:07:13 +0100 (CET) Received: (qmail 48012 invoked by uid 500); 24 Dec 2018 01:07:13 -0000 Mailing-List: contact commits-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list commits@qpid.apache.org Received: (qmail 48003 invoked by uid 99); 24 Dec 2018 01:07:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Dec 2018 01:07:12 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 337BF821AE; Mon, 24 Dec 2018 01:07:12 +0000 (UTC) Date: Mon, 24 Dec 2018 01:07:12 +0000 To: "commits@qpid.apache.org" Subject: [qpid-dispatch] branch master updated: NO-JIRA: fix spurious hang in fake broker unit tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <154561363211.28115.6766408644778558830@gitbox.apache.org> From: kgiusti@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: qpid-dispatch X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 181d97b6879e67b1c4b3117e8710e01bd7ee06bf X-Git-Newrev: b74263e8a7eceff7a7fcf71735c8765ed3fb52ef X-Git-Rev: b74263e8a7eceff7a7fcf71735c8765ed3fb52ef X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. kgiusti pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git The following commit(s) were added to refs/heads/master by this push: new b74263e NO-JIRA: fix spurious hang in fake broker unit tests b74263e is described below commit b74263e8a7eceff7a7fcf71735c8765ed3fb52ef Author: Kenneth Giusti AuthorDate: Sun Dec 23 19:51:50 2018 -0500 NO-JIRA: fix spurious hang in fake broker unit tests --- tests/test_broker.py | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tests/test_broker.py b/tests/test_broker.py index df60626..5eade13 100644 --- a/tests/test_broker.py +++ b/tests/test_broker.py @@ -107,15 +107,12 @@ class FakeBroker(MessagingHandler): while self._container.process(): if self._stop_thread: - break - - if self.acceptor: - self.acceptor.close() - self.acceptor = None - for c in self._connections: - c.close() - self._connections = [] - self._container.process() + if self.acceptor: + self.acceptor.close() + self.acceptor = None + for c in self._connections: + c.close() + self._connections = [] def join(self): self._stop_thread = True --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org For additional commands, e-mail: commits-help@qpid.apache.org