qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kgiu...@apache.org
Subject [qpid-dispatch] branch master updated: NO-JIRA: fix spurious hang in fake broker unit tests
Date Mon, 24 Dec 2018 01:07:12 GMT
This is an automated email from the ASF dual-hosted git repository.

kgiusti pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git


The following commit(s) were added to refs/heads/master by this push:
     new b74263e  NO-JIRA: fix spurious hang in fake broker unit tests
b74263e is described below

commit b74263e8a7eceff7a7fcf71735c8765ed3fb52ef
Author: Kenneth Giusti <kgiusti@apache.org>
AuthorDate: Sun Dec 23 19:51:50 2018 -0500

    NO-JIRA: fix spurious hang in fake broker unit tests
---
 tests/test_broker.py | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/tests/test_broker.py b/tests/test_broker.py
index df60626..5eade13 100644
--- a/tests/test_broker.py
+++ b/tests/test_broker.py
@@ -107,15 +107,12 @@ class FakeBroker(MessagingHandler):
 
         while self._container.process():
             if self._stop_thread:
-                break
-
-        if self.acceptor:
-            self.acceptor.close()
-            self.acceptor = None
-        for c in self._connections:
-            c.close()
-        self._connections = []
-        self._container.process()
+                if self.acceptor:
+                    self.acceptor.close()
+                    self.acceptor = None
+                for c in self._connections:
+                    c.close()
+                self._connections = []
 
     def join(self):
         self._stop_thread = True


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message