From commits-return-46381-archive-asf-public=cust-asf.ponee.io@qpid.apache.org Thu Aug 2 16:56:48 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BADE6180629 for ; Thu, 2 Aug 2018 16:56:47 +0200 (CEST) Received: (qmail 71625 invoked by uid 500); 2 Aug 2018 14:56:46 -0000 Mailing-List: contact commits-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list commits@qpid.apache.org Received: (qmail 71616 invoked by uid 99); 2 Aug 2018 14:56:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2018 14:56:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C1371E0181; Thu, 2 Aug 2018 14:56:46 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: aconway@apache.org To: commits@qpid.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: qpid-proton git commit: NO-JIRA: [cpp] Fix doxygen warnings, missing trivial comments Date: Thu, 2 Aug 2018 14:56:46 +0000 (UTC) Repository: qpid-proton Updated Branches: refs/heads/master d722f7df5 -> 8c3d7f491 NO-JIRA: [cpp] Fix doxygen warnings, missing trivial comments Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/8c3d7f49 Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/8c3d7f49 Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/8c3d7f49 Branch: refs/heads/master Commit: 8c3d7f491575ddc78128f820a6015f3c6c273525 Parents: d722f7d Author: Alan Conway Authored: Thu Aug 2 10:54:22 2018 -0400 Committer: Alan Conway Committed: Thu Aug 2 10:54:22 2018 -0400 ---------------------------------------------------------------------- cpp/include/proton/null.hpp | 4 ++-- cpp/include/proton/value.hpp | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/8c3d7f49/cpp/include/proton/null.hpp ---------------------------------------------------------------------- diff --git a/cpp/include/proton/null.hpp b/cpp/include/proton/null.hpp index cb39325..f9c44ff 100644 --- a/cpp/include/proton/null.hpp +++ b/cpp/include/proton/null.hpp @@ -43,9 +43,9 @@ class null : private internal::comparable { /// Constructed from nullptr literal null(decltype(nullptr)) {} #endif - // null instances are always equal + /// null instances are always equal friend bool operator==(const null&, const null&) { return true; } - // null instances are never unequal + /// null instances are never unequal friend bool operator<(const null&, const null&) { return false; } }; http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/8c3d7f49/cpp/include/proton/value.hpp ---------------------------------------------------------------------- diff --git a/cpp/include/proton/value.hpp b/cpp/include/proton/value.hpp index ee50cbf..896ad41 100644 --- a/cpp/include/proton/value.hpp +++ b/cpp/include/proton/value.hpp @@ -155,11 +155,12 @@ template void coerce(const value& v, T& x) { } } -/// Special case for get(), just checks that value contains NULL. +/// Special case for null, just checks that value contains NULL. template<> inline void get(const value& v, null&) { assert_type_equal(NULL_TYPE, v.type()); } #if PN_CPP_HAS_NULLPTR +/// @copybrief get() template<> inline void get(const value& v, decltype(nullptr)&) { assert_type_equal(NULL_TYPE, v.type()); } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org For additional commands, e-mail: commits-help@qpid.apache.org