qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acon...@apache.org
Subject qpid-proton git commit: NO-JIRA: [c, cpp] Clean up out-of-date FIXME comments.
Date Fri, 06 Jul 2018 17:59:18 GMT
Repository: qpid-proton
Updated Branches:
  refs/heads/master 9778eda8e -> 252451f0a


NO-JIRA: [c,cpp] Clean up out-of-date FIXME comments.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/252451f0
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/252451f0
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/252451f0

Branch: refs/heads/master
Commit: 252451f0ad06e6f29c6eb424ba31ead5e4b53545
Parents: 9778eda
Author: Alan Conway <aconway@redhat.com>
Authored: Fri Jul 6 13:58:21 2018 -0400
Committer: Alan Conway <aconway@redhat.com>
Committed: Fri Jul 6 13:58:44 2018 -0400

----------------------------------------------------------------------
 c/docs/buffering.md                | 2 +-
 c/tests/threaderciser.c            | 4 +---
 cpp/src/connection_driver_test.cpp | 2 --
 cpp/src/value_test.cpp             | 3 +--
 4 files changed, 3 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/252451f0/c/docs/buffering.md
----------------------------------------------------------------------
diff --git a/c/docs/buffering.md b/c/docs/buffering.md
index a938205..71dafbf 100644
--- a/c/docs/buffering.md
+++ b/c/docs/buffering.md
@@ -45,4 +45,4 @@ throughput under load (bigger buffer).
 
 ### Incoming Data
 
-To Be Done... <!-- FIXME aconway 2018-05-03:  -->
+To Be Done... <!-- TODO aconway 2018-05-03:  -->

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/252451f0/c/tests/threaderciser.c
----------------------------------------------------------------------
diff --git a/c/tests/threaderciser.c b/c/tests/threaderciser.c
index 552ccb0..71400eb 100644
--- a/c/tests/threaderciser.c
+++ b/c/tests/threaderciser.c
@@ -430,7 +430,7 @@ static bool handle(global *g, pn_event_t *e) {
 
    case PN_CONNECTION_WAKE: {
      if (!action_enabled[A_CLOSE_CONNECT] && maybe(0.5)) pn_connection_close(c);
-     /* FIXME aconway 2018-05-16: connection release/re-use */
+     /* TODO aconway 2018-05-16: connection release/re-use */
      break;
    }
 
@@ -454,8 +454,6 @@ static bool handle(global *g, pn_event_t *e) {
     pn_proactor_interrupt(g->proactor); /* Pass the interrupt along */
     return false;
 
-    /* FIXME aconway 2018-03-09: MORE */
-
    default:
     break;
   }

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/252451f0/cpp/src/connection_driver_test.cpp
----------------------------------------------------------------------
diff --git a/cpp/src/connection_driver_test.cpp b/cpp/src/connection_driver_test.cpp
index 5be857e..9583f59 100644
--- a/cpp/src/connection_driver_test.cpp
+++ b/cpp/src/connection_driver_test.cpp
@@ -348,8 +348,6 @@ void test_link_address() {
     record_handler ha, hb;
     driver_pair d(ha, hb);
 
-    // FIXME aconway 2018-06-14: also fixes PROTON-1679?
-
     // Using open(address, opts)
     d.a.connection().open_sender("tx", sender_options().name("_x").source(source_options().address("sx")));
     d.a.connection().open_receiver("sy", receiver_options().name("_y").target(target_options().address("ty")));

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/252451f0/cpp/src/value_test.cpp
----------------------------------------------------------------------
diff --git a/cpp/src/value_test.cpp b/cpp/src/value_test.cpp
index 5e3eefd..64a1d72 100644
--- a/cpp/src/value_test.cpp
+++ b/cpp/src/value_test.cpp
@@ -96,8 +96,7 @@ void null_test() {
     vm[n] = 1;
     vm[nulls1] = 2;
     vm[nulls] = 3;
-    // FIXME aconway 2018-06-29: note different types compare by type-id,
-    // so NULL < ARRAY < LIST
+    // Different types compare by type-id, so NULL < ARRAY < LIST
     ASSERT_EQUAL("{null=1, @PN_NULL[null, null]=2, [null, null]=3}", to_string(vm));
 
     std::map<proton::scalar, proton::scalar> vm2;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message