qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acon...@apache.org
Subject qpid-proton git commit: PROTON-1540: [go] disabled race detection by default (again)
Date Mon, 04 Dec 2017 16:18:21 GMT
Repository: qpid-proton
Updated Branches:
  refs/heads/master 3fed547e3 -> 25efd103a


PROTON-1540: [go] disabled race detection by default (again)

NOTE: go test -race flag is not included by default, it causes problems on several platforms:
- ubuntu up to trust: link errors
- ubuntu from xenial: requires extra package golang-race-detector-runtime
- fedora with gccgo: complains about "import cycles"
(Works well on fedora with original go)
Enable manually with -DGO_TEST_FLAGS="-v -race"


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/25efd103
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/25efd103
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/25efd103

Branch: refs/heads/master
Commit: 25efd103a84a666c9da5e05cad5fbd2d12edf6f4
Parents: 3fed547
Author: Alan Conway <aconway@redhat.com>
Authored: Mon Dec 4 11:17:23 2017 -0500
Committer: Alan Conway <aconway@redhat.com>
Committed: Mon Dec 4 11:17:23 2017 -0500

----------------------------------------------------------------------
 proton-c/bindings/go/CMakeLists.txt | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/25efd103/proton-c/bindings/go/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/proton-c/bindings/go/CMakeLists.txt b/proton-c/bindings/go/CMakeLists.txt
index d24ce6a..4acd4e3 100644
--- a/proton-c/bindings/go/CMakeLists.txt
+++ b/proton-c/bindings/go/CMakeLists.txt
@@ -21,16 +21,21 @@
 execute_process(COMMAND ${GO_EXE} version OUTPUT_VARIABLE go_ver OUTPUT_STRIP_TRAILING_WHITESPACE)
 message(STATUS "Found Go: ${GO_EXE} (${go_ver})")
 
+# NOTE: go test -race flag is not included by default, it causes problems on several platforms:
+# - ubuntu up to trust: link errors
+# - ubuntu from xenial: requires extra package golang-race-detector-runtime
+# - fedora with gccgo: complains about "import cycles"
+# (Works well on fedora with original go)
+# Enable manually with -DGO_TEST_FLAGS="-v -race"
+
 set(GO_BUILD_FLAGS "" CACHE STRING "Flags for 'go build'")
 set(GO_VET_FLAGS "-v" CACHE STRING "Flags for 'go test'")
+set(GO_TEST_FLAGS "-v" CACHE STRING "Flags for 'go test'")
 
 # Flags that differ for golang go and gcc go.
 if (go_ver MATCHES "gccgo")
-  # -race causes import cycles with gccgo.
-  set(GO_TEST_FLAGS "-v" CACHE STRING "Flags for 'go test'")
   set(GO_RPATH_FLAGS -gccgoflags "-Wl,-rpath=${CMAKE_BINARY_DIR}/proton-c")
 else()
-  set(GO_TEST_FLAGS "-v -race" CACHE STRING "Flags for 'go test'")
   set(GO_RPATH_FLAGS -ldflags "-r ${CMAKE_BINARY_DIR}/proton-c")
 endif()
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message