qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From oru...@apache.org
Subject [1/4] qpid-broker-j git commit: QPID-7531: [Java Broker, AMQP 1.0] Remove or update TODOs
Date Fri, 06 Oct 2017 14:48:18 GMT
Repository: qpid-broker-j
Updated Branches:
  refs/heads/master 37b1a71ae -> 024f9a21a


 QPID-7531: [Java Broker, AMQP 1.0] Remove or update TODOs


Project: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/commit/826ff456
Tree: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/tree/826ff456
Diff: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/diff/826ff456

Branch: refs/heads/master
Commit: 826ff456c9bd48c37a01935d81b1b719f4cd27d1
Parents: 37b1a71
Author: Alex Rudyy <orudyy@apache.org>
Authored: Fri Oct 6 11:41:00 2017 +0100
Committer: Alex Rudyy <orudyy@apache.org>
Committed: Fri Oct 6 11:41:00 2017 +0100

----------------------------------------------------------------------
 .../org/apache/qpid/server/protocol/v1_0/Session_1_0.java    | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/826ff456/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java
----------------------------------------------------------------------
diff --git a/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java
b/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java
index 0f4b7ba..6505bcd 100644
--- a/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java
+++ b/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/Session_1_0.java
@@ -248,7 +248,6 @@ public class Session_1_0 extends AbstractAMQPSession<Session_1_0, ConsumerTarget
         }
 
         send(disposition);
-        //TODO - check send flow
     }
 
     void updateDisposition(final Role role,
@@ -483,11 +482,6 @@ public class Session_1_0 extends AbstractAMQPSession<Session_1_0,
ConsumerTarget
             }
             deliveryId.incr();
         }
-        if(Boolean.TRUE.equals(disposition.getSettled()))
-        {
-            //TODO - check send flow
-        }
-
     }
 
     public SessionState getSessionState()
@@ -1149,7 +1143,7 @@ public class Session_1_0 extends AbstractAMQPSession<Session_1_0,
ConsumerTarget
     @Override
     public void addDeleteTask(final Action<? super Session_1_0> task)
     {
-        // TODO is the closed guard important?
+        // TODO: QPID-7951 is the closed guard important?
         if(!_closed.get())
         {
             super.addDeleteTask(task);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message