qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tr...@apache.org
Subject [3/9] qpid-dispatch git commit: DISPATCH-847 - Fixed Coverity issue 181416 (Use after free)
Date Wed, 04 Oct 2017 14:48:47 GMT
DISPATCH-847 - Fixed Coverity issue 181416 (Use after free)


Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/f293015b
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/f293015b
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/f293015b

Branch: refs/heads/master
Commit: f293015b3f3a41a1791fe39a500bd1d5e43461f1
Parents: d0dcac4
Author: Ted Ross <tross@redhat.com>
Authored: Wed Oct 4 09:59:40 2017 -0400
Committer: Ted Ross <tross@redhat.com>
Committed: Wed Oct 4 09:59:40 2017 -0400

----------------------------------------------------------------------
 src/router_core/transfer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/f293015b/src/router_core/transfer.c
----------------------------------------------------------------------
diff --git a/src/router_core/transfer.c b/src/router_core/transfer.c
index 373e439..dcd7563 100644
--- a/src/router_core/transfer.c
+++ b/src/router_core/transfer.c
@@ -1108,8 +1108,8 @@ static void qdr_deliver_continue_CT(qdr_core_t *core, qdr_action_t *action,
bool
 
             // Remove the delivery from the settled list and decref the in_dlv.
             in_dlv->where = QDR_DELIVERY_NOWHERE;
-            qdr_delivery_decref_CT(core, in_dlv); // This decref is for removing the delivery
from the settled list.
             DEQ_REMOVE(in_dlv->link->settled, in_dlv);
+            qdr_delivery_decref_CT(core, in_dlv); // This decref is for removing the delivery
from the settled list.
         }
     }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message