qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitc...@apache.org
Subject qpid-proton git commit: PROTON-1616: Revert erroneous fix for coverity false positive
Date Tue, 31 Oct 2017 04:30:14 GMT
Repository: qpid-proton
Updated Branches:
  refs/heads/master 738c1980e -> de3fd6172


PROTON-1616: Revert erroneous fix for coverity false positive


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/de3fd617
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/de3fd617
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/de3fd617

Branch: refs/heads/master
Commit: de3fd617210b5d5a2f2c3e384c33905dbf75ad58
Parents: 738c198
Author: Andrew Stitcher <astitcher@apache.org>
Authored: Tue Oct 31 00:29:33 2017 -0400
Committer: Andrew Stitcher <astitcher@apache.org>
Committed: Tue Oct 31 00:29:33 2017 -0400

----------------------------------------------------------------------
 proton-c/src/sasl/default_sasl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/de3fd617/proton-c/src/sasl/default_sasl.c
----------------------------------------------------------------------
diff --git a/proton-c/src/sasl/default_sasl.c b/proton-c/src/sasl/default_sasl.c
index 64ffd3a..66dd318 100644
--- a/proton-c/src/sasl/default_sasl.c
+++ b/proton-c/src/sasl/default_sasl.c
@@ -159,7 +159,7 @@ bool default_sasl_process_mechanisms(pn_transport_t *transport, const
char *mech
       pnx_sasl_is_included_mech(transport, pn_bytes(9, found))) {
     pnx_sasl_set_selected_mechanism(transport, ANONYMOUS);
     if (username) {
-      size_t size = strlen(username+1);
+      size_t size = strlen(username);
       char *iresp = (char *) malloc(size);
       if (!iresp) return false;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message