qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From c...@apache.org
Subject qpid-dispatch git commit: DISPATCH-798: Description of maxSessionWindow in doc is wrong
Date Tue, 10 Oct 2017 18:30:10 GMT
Repository: qpid-dispatch
Updated Branches:
  refs/heads/master 1e6164dc5 -> 69ee4b85f


DISPATCH-798: Description of maxSessionWindow in doc is wrong

Clarify what units maxSessionWindow uses and how is used internally.
Correct examples to use the setting correctly.


Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/69ee4b85
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/69ee4b85
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/69ee4b85

Branch: refs/heads/master
Commit: 69ee4b85f413bab6972867d0c3a91c8fb6f29959
Parents: 1e6164d
Author: Chuck Rolke <crolke@redhat.com>
Authored: Tue Oct 10 14:27:40 2017 -0400
Committer: Chuck Rolke <crolke@redhat.com>
Committed: Tue Oct 10 14:27:40 2017 -0400

----------------------------------------------------------------------
 doc/book/policy.adoc | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/69ee4b85/doc/book/policy.adoc
----------------------------------------------------------------------
diff --git a/doc/book/policy.adoc b/doc/book/policy.adoc
index 075e3f8..645334f 100644
--- a/doc/book/policy.adoc
+++ b/doc/book/policy.adoc
@@ -153,7 +153,7 @@ This object is the data value contained in entries in the policy/groups
map.
 | maxFrameSize         | 2^31-1  | Largest frame that may be sent on this connection. (AMQP
Open, max-frame-size)
 | maxSessions          | 65535   | Maximum number of sessions that may be created on this
connection. (AMQP Open, channel-max)
 | *AMQP Session Begin Limits*    | |
-| maxSessionWindow     | 2^31-1  |Incoming capacity for new sessions. (AMQP Begin, incoming-window)
+| maxSessionWindow     | 2^31-1  |Incoming capacity for new sessions measured in octets.
AMQP Begin, incoming-window measured in AMQP frames is calculated by (maxSessionWindow / maxFrameSize).
(AMQP Begin, incoming-window)
 | *AMQP Link Attach*             | |
 | maxMessageSize       | 0       | Largest message size supported by links created on this
connection. If this field is zero there is no maximum size imposed by the link endpoint. (AMQP
Attach, max-message-size)
 | maxSenders           | 2^31-1  | Maximum number of sending links that may be created on
this connection.
@@ -299,13 +299,9 @@ vhost {
 Policy provides a mechanism to control how much system buffer memory a
 user connection can potentially consume. The formula for computing
 buffer memory consumption for each session is
+set directly by _maxSessionWindow_.
 
-[optons="nowrap"]
-----
-  potential buffer usage = maxFrameSize * maxSessionWindow
-----
-
-By adjusting _maxFrameSize_, _maxSessions_, and _maxSessionWindow_ an
+By adjusting _maxSessions_, and _maxSessionWindow_ an
 administrator can prevent a user from consuming too much memory by
 buffering messages in flight.
 
@@ -330,14 +326,14 @@ vhost {
         traders: {
             users: trader-1, trader-2, ...       <2>
             maxFrameSize: 10000                  <3>
-            maxSessionWindow: 500                <3>
+            maxSessionWindow: 5000000            <3>
             maxSessions: 1                       <4>
             ...
         },
         feeds: {
             users: nyse-feed, nasdaq-feed        <5>
             maxFrameSize: 60000                  <6>
-            maxSessionWindow: 20000              <6>
+            maxSessionWindow: 1200000000         <6>
             maxSessions: 3                       <7>
             ...
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message