Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 91C19200CA4 for ; Wed, 7 Jun 2017 17:39:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9059C160BE2; Wed, 7 Jun 2017 15:39:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D85A1160BB6 for ; Wed, 7 Jun 2017 17:39:37 +0200 (CEST) Received: (qmail 77616 invoked by uid 500); 7 Jun 2017 15:39:37 -0000 Mailing-List: contact commits-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list commits@qpid.apache.org Received: (qmail 77606 invoked by uid 99); 7 Jun 2017 15:39:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2017 15:39:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F1ED2DFF81; Wed, 7 Jun 2017 15:39:36 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: orudyy@apache.org To: commits@qpid.apache.org Date: Wed, 07 Jun 2017 15:39:36 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] qpid-broker-j git commit: QPID-7816: [Java Broker] Add test sending transfer without a delivery tag archived-at: Wed, 07 Jun 2017 15:39:38 -0000 Repository: qpid-broker-j Updated Branches: refs/heads/master 6ee02c1ef -> 4b4f1cd75 QPID-7816: [Java Broker] Add test sending transfer without a delivery tag Project: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/commit/4b4f1cd7 Tree: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/tree/4b4f1cd7 Diff: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/diff/4b4f1cd7 Branch: refs/heads/master Commit: 4b4f1cd7595388152b15c84645e748d07b15c873 Parents: aa1f6ff Author: Alex Rudyy Authored: Wed Jun 7 15:15:25 2017 +0100 Committer: Alex Rudyy Committed: Wed Jun 7 16:38:55 2017 +0100 ---------------------------------------------------------------------- .../protocol/v1_0/messaging/TransferTest.java | 31 ++++++++++++++++++++ 1 file changed, 31 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/4b4f1cd7/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/messaging/TransferTest.java ---------------------------------------------------------------------- diff --git a/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/messaging/TransferTest.java b/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/messaging/TransferTest.java index 3e57371..92781d5 100644 --- a/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/messaging/TransferTest.java +++ b/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/messaging/TransferTest.java @@ -96,6 +96,37 @@ public class TransferTest extends ProtocolTestBase } } + @Ignore("QPID-7816") + @Test + @SpecificationTest(section = "2.7.5", + description = "[delivery-tag] MUST be specified for the first transfer " + + "[...] and can only be omitted for continuation transfers.") + public void transferWithoutDeliveryTag() throws Exception + { + try (FrameTransport transport = new FrameTransport(_brokerAddress)) + { + final UnsignedInteger linkHandle = UnsignedInteger.ONE; + transport.doAttachSendingLink(linkHandle, BrokerAdmin.TEST_QUEUE_NAME); + + MessageEncoder messageEncoder = new MessageEncoder(); + messageEncoder.addData("foo"); + + Transfer transfer = new Transfer(); + transfer.setHandle(linkHandle); + transfer.setDeliveryId(UnsignedInteger.ZERO); + transfer.setPayload(messageEncoder.getPayload()); + + transport.sendPerformative(transfer); + PerformativeResponse response = (PerformativeResponse) transport.getNextResponse(); + + assertThat(response, is(notNullValue())); + assertThat(response.getFrameBody(), is(instanceOf(Close.class))); + Close responseClose = (Close) response.getFrameBody(); + assertThat(responseClose.getError(), is(notNullValue())); + assertThat(responseClose.getError().getCondition(), equalTo(AmqpError.INVALID_FIELD)); + } + } + @Test @SpecificationTest(section = "2.6.12", description = "Transferring A Message.") --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org For additional commands, e-mail: commits-help@qpid.apache.org