qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cliffjan...@apache.org
Subject qpid-proton git commit: PROTON-1460: epoll lower HOGMAX for better performance
Date Tue, 16 May 2017 15:20:58 GMT
Repository: qpid-proton
Updated Branches:
  refs/heads/master b0be770d7 -> adb17eb72


PROTON-1460: epoll lower HOGMAX for better performance


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/adb17eb7
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/adb17eb7
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/adb17eb7

Branch: refs/heads/master
Commit: adb17eb727ef914e03f7cb542a02b2a32a48afee
Parents: b0be770
Author: Clifford Jansen <cliffjansen@apache.org>
Authored: Tue May 16 08:20:14 2017 -0700
Committer: Clifford Jansen <cliffjansen@apache.org>
Committed: Tue May 16 08:20:14 2017 -0700

----------------------------------------------------------------------
 proton-c/src/proactor/epoll.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/adb17eb7/proton-c/src/proactor/epoll.c
----------------------------------------------------------------------
diff --git a/proton-c/src/proactor/epoll.c b/proton-c/src/proactor/epoll.c
index 9fd7d06..d79f0da 100644
--- a/proton-c/src/proactor/epoll.c
+++ b/proton-c/src/proactor/epoll.c
@@ -210,10 +210,10 @@ const char *AMQP_PORT_NAME = "amqp";
 PN_HANDLE(PN_PROACTOR)
 
 // The number of times a connection event batch may be replenished for
-// a thread between calls to wait().
-// TODO: consider some instrumentation to determine an optimal number
-// or perhaps switch to cpu time based limit.
-#define HOG_MAX 3
+// a thread between calls to wait().  Some testing shows that
+// increasing this value above 1 actually slows performance slightly
+// and increases latency.
+#define HOG_MAX 1
 
 /* pn_proactor_t and pn_listener_t are plain C structs with normal memory management.
    Class definitions are for identification as pn_event_t context only.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message