qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitc...@apache.org
Subject [3/3] qpid-proton git commit: PROTON-1281: [C++ Binding] Missed #include <ostream> - This was causing a difficult to find link error on FreeBSD/clang++
Date Thu, 11 Aug 2016 17:31:45 GMT
PROTON-1281: [C++ Binding] Missed #include <ostream>
- This was causing a difficult to find link error on FreeBSD/clang++

  The code in question was using ostream& << std::string("whatever");
  but only including <string> which only declares the operator<< used.

  However you need <ostream> to define the necessary template instantiation.
  If you don't include <ostream> then it becomes an unknown symbol.

  This only happens when compiling with -O2 or -O3. I think this is
  because these options inline the template instantiation in other
  places so that the symbol is not available in the library anymore.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/5bd761b0
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/5bd761b0
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/5bd761b0

Branch: refs/heads/0.14.x
Commit: 5bd761b0798e67dd99f3df0a7cc06b9f69417b2c
Parents: ec38ff0
Author: Andrew Stitcher <astitcher@apache.org>
Authored: Tue Aug 9 09:55:38 2016 -0400
Committer: Andrew Stitcher <astitcher@apache.org>
Committed: Thu Aug 11 13:26:22 2016 -0400

----------------------------------------------------------------------
 proton-c/bindings/cpp/src/error_condition.cpp      | 3 +++
 proton-c/bindings/cpp/src/io/connection_engine.cpp | 1 -
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/5bd761b0/proton-c/bindings/cpp/src/error_condition.cpp
----------------------------------------------------------------------
diff --git a/proton-c/bindings/cpp/src/error_condition.cpp b/proton-c/bindings/cpp/src/error_condition.cpp
index b927077..ead1cff 100644
--- a/proton-c/bindings/cpp/src/error_condition.cpp
+++ b/proton-c/bindings/cpp/src/error_condition.cpp
@@ -19,10 +19,13 @@
  *
  */
 #include "proton/error_condition.hpp"
+
 #include <proton/condition.h>
 
 #include "proton_bits.hpp"
 
+#include <ostream>
+
 namespace proton {
 
 error_condition::error_condition(pn_condition_t* c) :

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/5bd761b0/proton-c/bindings/cpp/src/io/connection_engine.cpp
----------------------------------------------------------------------
diff --git a/proton-c/bindings/cpp/src/io/connection_engine.cpp b/proton-c/bindings/cpp/src/io/connection_engine.cpp
index f15b019..e520547 100644
--- a/proton-c/bindings/cpp/src/io/connection_engine.cpp
+++ b/proton-c/bindings/cpp/src/io/connection_engine.cpp
@@ -36,7 +36,6 @@
 
 #include <algorithm>
 
-#include <iosfwd>
 
 namespace proton {
 namespace io {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message